[webkit-changes] [WebKit/WebKit] e73d11: [Safer-CPP] PR with modified expectations results ...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e73d1174446fd807f761bbe16d20dfbdedd71326
      https://github.com/WebKit/WebKit/commit/e73d1174446fd807f761bbe16d20dfbdedd71326
  Author: Brianna Fan <bfan2 at apple.com>
  Date:   2025-03-11 (Tue, 11 Mar 2025)

  Changed paths:
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  [Safer-CPP] PR with modified expectations results in "0 new failure" after second build
https://bugs.webkit.org/show_bug.cgi?id=289494
rdar://146329623

Reviewed by Aakash Jain.

Fix various smaller bugs that led to this outcome.
The biggest one is deleting the full results before generating the index with filtered results.

* Tools/CISupport/ews-build/steps.py:
(FindUnexpectedStaticAnalyzerResults.run):
(FindUnexpectedStaticAnalyzerResultsWithoutChange.run):
    - Only delete results after we finish all possible operations.
(FindUnexpectedStaticAnalyzerResultsWithoutChange.filter_results_by_user_modification):
    - Remove duplicates from the count of failing/passing files.
(DisplaySaferCPPResults.run):
    - We should add the failure URL if there are failing files.
(DisplaySaferCPPResults.createComment):
    - Report the number of failing files and issues if that data exists.
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/291979@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications