[webkit-changes] [WebKit/WebKit] 021b50: Remove and replace `WKBundlePageFindString`

Charlie Wolfe noreply at github.com
Wed Mar 5 17:33:19 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 021b503e732e25b69332cfa87427d80e881fd036
      https://github.com/WebKit/WebKit/commit/021b503e732e25b69332cfa87427d80e881fd036
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2025-03-05 (Wed, 05 Mar 2025)

  Changed paths:
    M LayoutTests/editing/text-iterator/findString.html
    M Source/WebKit/UIProcess/API/C/WKPage.cpp
    M Source/WebKit/UIProcess/API/C/WKPagePrivate.h
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/mac/WebKit2.order
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
    M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
    M Tools/WebKitTestRunner/TestController.cpp

  Log Message:
  -----------
  Remove and replace `WKBundlePageFindString`
https://bugs.webkit.org/show_bug.cgi?id=288959
rdar://146003367

Reviewed by Pascoe.

This makes testRunner.findString() behave correctly with site isolation.

* LayoutTests/editing/text-iterator/findString.html:
* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageFindStringForTesting):
* Source/WebKit/UIProcess/API/C/WKPagePrivate.h:
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageFindString): Deleted.
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::findStringFromInjectedBundle): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/mac/WebKit2.order:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::postMessageWithAsyncReply):
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::findString):
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveAsyncMessageFromInjectedBundle):

Canonical link: https://commits.webkit.org/291668@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list