[webkit-changes] [WebKit/WebKit] a818d2: [Grid] Rename dirtyGrid to setNeedsItemPlacement

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a818d29b0418aef3b313b0439e73bee763adae41
      https://github.com/WebKit/WebKit/commit/a818d29b0418aef3b313b0439e73bee763adae41
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2025-03-05 (Wed, 05 Mar 2025)

  Changed paths:
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderGrid.cpp
    M Source/WebCore/rendering/RenderGrid.h
    M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp

  Log Message:
  -----------
  [Grid] Rename dirtyGrid to setNeedsItemPlacement
https://bugs.webkit.org/show_bug.cgi?id=289178
rdar://146312865

Reviewed by Brandon Stewart.

This function just marks the "needs item placement," bit on the
associated RenderGrid (and potentially ancestor RenderGrids if it is a
subgrid). Let's rename the function to setNeedsItemPlacement to make it
more clear that this is what this function does.

* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::updateGridPositionAfterStyleChange):
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::styleDidChange):
(WebCore::RenderGrid::setNeedsItemPlacement):
(WebCore::RenderGrid::dirtyGrid): Deleted.
* Source/WebCore/rendering/RenderGrid.h:
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::childFlowStateChangesAndAffectsParentBlock):
(WebCore::RenderTreeBuilder::detachFromRenderGrid):
(WebCore::RenderTreeBuilder::attachToRenderGrid):

Canonical link: https://commits.webkit.org/291654@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications