[webkit-changes] [WebKit/WebKit] 1974b4: webengineshackfest.org: 'close' button does not sh...

[Vitor Roriz]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1974b406003ac77007e217bdc12b858b9c029a95
      https://github.com/WebKit/WebKit/commit/1974b406003ac77007e217bdc12b858b9c029a95
  Author: Vitor Roriz <vitor.roriz at apple.com>
  Date:   2025-01-31 (Fri, 31 Jan 2025)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-presented-as-emoji-outline-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-presented-as-emoji-outline-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-presented-as-emoji-outline.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/resources/AhemCrossmarkSupport.otf
    M Source/WebCore/platform/graphics/FontCascadeFonts.cpp

  Log Message:
  -----------
  webengineshackfest.org: 'close' button does not show 'emoji' inside on WebKit / Safari
rdar://128019815
https://bugs.webkit.org/show_bug.cgi?id=286749

Reviewed by Sammy Gill.

At commit [1] we improved the rendering of glyphs that should be presented as emoji
according to unicode. This commit makes sure that if we find a font that support
a given "emoji presented" codepoint but this font can't render the emoji in a colorful way,
we will continuing falling back.

The problem is that if the author specifies a font that can represent the codepoint
but as a outline, we will refuse to render that codepoint with such a font, which is
the bug here reported.

Here we are proposing to honor the solution of [1] only if a generic font family is specified.
That way, if author specifies something like `font-family: system-ui` we will try to find the
best system font we can with colorful glyphs. Otherwise, if author specifies a non-generic font
that can support the codepoint we will use this font.

[1]: https://commits.webkit.org/266089@main

* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-presented-as-emoji-outline-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-presented-as-emoji-outline-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-presented-as-emoji-outline.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/resources/AhemCrossmarkSupport.otf: Added.
* Source/WebCore/platform/graphics/FontCascadeFonts.cpp:
(WebCore::FontCascadeFonts::glyphDataForVariant):

Canonical link: https://commits.webkit.org/289653@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications