[webkit-changes] [WebKit/WebKit] dff143: [WASM] Tail calls should consume expression stack ...

[David Degazio]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dff14391ec0349aba5b843488112cc21b7b492cc
      https://github.com/WebKit/WebKit/commit/dff14391ec0349aba5b843488112cc21b7b492cc
  Author: David Degazio <d_degazio at apple.com>
  Date:   2025-01-31 (Fri, 31 Jan 2025)

  Changed paths:
    A JSTests/wasm/stress/tail-call-should-consume-stack-in-bbq.js
    M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp

  Log Message:
  -----------
  [WASM] Tail calls should consume expression stack after call in BBQ
https://bugs.webkit.org/show_bug.cgi?id=284159
rdar://141164805

Reviewed by Yusuke Suzuki.

Adds a loop to consume expression stack elements after we
generate a tail call (direct or indirect) in BBQ. This is
consistent with our behavior in the return opcode, and
prevents register bindings from persisting into the
subsequent unreachable code.

* JSTests/wasm/stress/tail-call-should-consume-stack-in-bbq.js: Added.
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::emitTailCall):
(JSC::Wasm::BBQJITImpl::BBQJIT::emitIndirectTailCall):

Originally-landed-as: 283286.575 at safari-7620-branch (ca83d835b014). rdar://143593119
Canonical link: https://commits.webkit.org/289650@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications