[webkit-changes] [WebKit/WebKit] 433f89: Port WebExtensionStorageSQLiteStore to C++

[Jamie Murphy]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 433f8948107045bc3b0ad5d57caa56b19e43000c
      https://github.com/WebKit/WebKit/commit/433f8948107045bc3b0ad5d57caa56b19e43000c
  Author: Jamie <hello at itsjamie.dev>
  Date:   2025-01-31 (Fri, 31 Jan 2025)

  Changed paths:
    M Source/WebKit/Shared/Extensions/WebExtensionDataType.h
    M Source/WebKit/Shared/Extensions/WebExtensionSQLiteDatabase.cpp
    M Source/WebKit/Sources.txt
    A Source/WebKit/UIProcess/Extensions/API/WebExtensionContextAPIStorage.cpp
    R Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIStorageCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm
    R Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionStorageSQLiteStore.h
    R Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionStorageSQLiteStore.mm
    M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
    M Source/WebKit/UIProcess/Extensions/WebExtensionController.h
    A Source/WebKit/UIProcess/Extensions/WebExtensionStorageSQLiteStore.cpp
    A Source/WebKit/UIProcess/Extensions/WebExtensionStorageSQLiteStore.h
    M Source/WebKit/UIProcess/GPU/GPUProcessProxy.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Port WebExtensionStorageSQLiteStore to C++
https://webkit.org/b/286343

Reviewed by Timothy Hatcher.

This removes the old Cocoa implementation of WebExtensionStorageSQLiteStore, and creates a new c++ storage store
based off the new C++ WebExtensionSQLiteStore

* Source/WebKit/Sources.txt:
* Source/WebKit/UIProcess/Extensions/API/WebExtensionContextAPIStorage.cpp: Renamed from Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIStorageCocoa.mm.
(WebKit::WebExtensionContext::isStorageMessageAllowed):
(WebKit::WebExtensionContext::storageGet):
(WebKit::WebExtensionContext::storageGetKeys):
(WebKit::WebExtensionContext::storageGetBytesInUse):
(WebKit::WebExtensionContext::storageSet):
(WebKit::WebExtensionContext::storageRemove):
(WebKit::WebExtensionContext::storageClear):
(WebKit::WebExtensionContext::fireStorageChangedEventIfNeeded):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::localStorageStore):
(WebKit::WebExtensionContext::sessionStorageStore):
(WebKit::WebExtensionContext::syncStorageStore):
(WebKit::WebExtensionContext::storageForType):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm:
(WebKit::WebExtensionController::getDataRecords):
(WebKit::WebExtensionController::getDataRecord):
(WebKit::WebExtensionController::removeData):
(WebKit::WebExtensionController::calculateStorageSize):
(WebKit::WebExtensionController::removeStorage):
(WebKit::WebExtensionController::sqliteStore):
* Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionStorageSQLiteStore.h: Removed.
* Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionStorageSQLiteStore.mm: Removed.
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionController.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionStorageSQLiteStore.cpp: Added.
(WebKit::rowFilterStringFromRowKeys):
(WebKit::WebExtensionStorageSQLiteStore::WebExtensionStorageSQLiteStore):
(WebKit::WebExtensionStorageSQLiteStore::getAllKeys):
(WebKit::WebExtensionStorageSQLiteStore::getValuesForKeys):
(WebKit::storageSizeOf):
(WebKit::WebExtensionStorageSQLiteStore::getStorageSizeForKeys):
(WebKit::hashmapToVector):
(WebKit::WebExtensionStorageSQLiteStore::getStorageSizeForAllKeys):
(WebKit::WebExtensionStorageSQLiteStore::setKeyedData):
(WebKit::WebExtensionStorageSQLiteStore::deleteValuesForKeys):
(WebKit::WebExtensionStorageSQLiteStore::insertOrUpdateValue):
(WebKit::WebExtensionStorageSQLiteStore::getValuesForAllKeys):
(WebKit::WebExtensionStorageSQLiteStore::getKeysAndValuesFromRowIterator):
(WebKit::WebExtensionStorageSQLiteStore::getAllKeysWithErrorMessage):
(WebKit::WebExtensionStorageSQLiteStore::getValuesForKeysWithErrorMessage):
(WebKit::WebExtensionStorageSQLiteStore::currentDatabaseSchemaVersion):
(WebKit::WebExtensionStorageSQLiteStore::createFreshDatabaseSchema):
(WebKit::WebExtensionStorageSQLiteStore::migrateToCurrentSchemaVersionIfNeeded):
(WebKit::WebExtensionStorageSQLiteStore::resetDatabaseSchema):
(WebKit::WebExtensionStorageSQLiteStore::isDatabaseEmpty):
(WebKit::WebExtensionStorageSQLiteStore::databaseURL):
* Source/WebKit/UIProcess/Extensions/WebExtensionStorageSQLiteStore.h: Added.
* Source/WebKit/UIProcess/GPU/GPUProcessProxy.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/289633@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications