[webkit-changes] [WebKit/WebKit] bd4af9: ASAN_TRAP in WebCore::FilterEffect::takeImageInput...

[Anil Hebbar]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd4af90cc0a25b949b09a93463e9d9028a7c20b3
      https://github.com/WebKit/WebKit/commit/bd4af90cc0a25b949b09a93463e9d9028a7c20b3
  Author: Anil Hebbar <anil_hebbar at apple.com>
  Date:   2025-01-31 (Fri, 31 Jan 2025)

  Changed paths:
    A LayoutTests/svg/filters/feMerge-zero-inputs-expected.txt
    A LayoutTests/svg/filters/feMerge-zero-inputs.html
    M Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp

  Log Message:
  -----------
  ASAN_TRAP in WebCore::FilterEffect::takeImageInputs called from WebCore::SVGFilter::apply
https://bugs.webkit.org/show_bug.cgi?id=286649
rdar://141026221

Reviewed by Said Abou-Hallawa.

The bug was caused by inputs to the FEMerge being size 0.
The original size was one, but the test script deleted the
child <feMergeNode>. This breaks the SVGFilter.
The fix is:
SVGFilterPrimitiveStandardAttributes::markFilterEffectForRebuild()
should clear m_effect even if the renderer is null.
This will force us to try to create a new one when
applying the broken SVGFilter.

* LayoutTests/svg/filters/feMerge-zero-inputs-expected.txt: Added.
* LayoutTests/svg/filters/feMerge-zero-inputs.html: Added.
* Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::markFilterEffectForRebuild):

Canonical link: https://commits.webkit.org/289632@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications