[webkit-changes] [WebKit/WebKit] cf6e3f: WebContent processes should not be able to disable...

Charlie Wolfe noreply at github.com
Fri Jan 31 11:31:13 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf6e3fe996f91fd48998dc47aae87f9455ec38d6
      https://github.com/WebKit/WebKit/commit/cf6e3fe996f91fd48998dc47aae87f9455ec38d6
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2025-01-31 (Fri, 31 Jan 2025)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
    M Source/WebKit/NetworkProcess/NetworkSession.h
    M Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm

  Log Message:
  -----------
  WebContent processes should not be able to disable third-party cookie blocking via ApplyTrackingPrevention
https://bugs.webkit.org/show_bug.cgi?id=283462
rdar://140320313

Reviewed by Sihui Liu.

This change removes a WebContent -> network process message parameter `ApplyTrackingPrevention` that
allows third-party cookie blocking to be disabled. The conditions that were being checked in the web
process to determine if tracking prevention should be applied should match the network process side
 function that all of these IPC endpoints use (`NetworkStorageSession::shouldBlockCookies`).

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOMAsync):
(WebKit::NetworkConnectionToWebProcess::setCookieFromDOMAsync):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkSession.h:
(WebKit::NetworkSession::thirdPartyCookieBlockingMode const):
* Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp:
(WebKit::shouldBlockCookies):
(WebKit::WebCookieJar::cookies const):
(WebKit::WebCookieJar::setCookies):
(WebKit::WebCookieJar::cookiesEnabled):
(WebKit::WebCookieJar::cookieRequestHeaderFieldValue const):
(WebKit::WebCookieJar::getRawCookies const):
(WebKit::WebCookieJar::getCookiesAsync const):
(WebKit::WebCookieJar::setCookieAsync const):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:
(EmptyFirstPartyForCookiesCookieRequestHeaderFieldValue)):
(InvalidSameSiteInfoCookieRequestHeaderFieldValue)):

Originally-landed-as: 283286.525 at safari-7620-branch (a8c083570032). https://bugs.webkit.org/show_bug.cgi?id=283462
Canonical link: https://commits.webkit.org/289623@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list