[webkit-changes] [WebKit/WebKit] e02f98: Hitting a release assertion in the WebExtension co...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e02f981365edfa06e7ad71c3316c9470e7ad7a30
      https://github.com/WebKit/WebKit/commit/e02f981365edfa06e7ad71c3316c9470e7ad7a30
  Author: Elijah Sawyers <esawyers at apple.com>
  Date:   2025-01-31 (Fri, 31 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm

  Log Message:
  -----------
  Hitting a release assertion in the WebExtension constructor if the resource URL doesn't contain a trailing slash
https://bugs.webkit.org/show_bug.cgi?id=286768
rdar://143775403

Reviewed by Timothy Hatcher.

This patch fixes a bug where we'd hit a release assert when trying to create
a WebExtension object with a resource URL that doesn't contain a trailing
slash.

We should relax this constraint and add a trailing slash if the URL doesn't
have one.

Addtionally, wrote a new test to cover this.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::WebExtension):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm:
(TestWebKitAPI::TEST(WKWebExtension, LoadFromDirectoryWithoutTrailingSlash)):

Canonical link: https://commits.webkit.org/289614@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications