[webkit-changes] [WebKit/WebKit] 312e1f: Pass along authorization token for touch events

Commit Queue noreply at github.com
Fri Jan 31 10:02:18 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 312e1f95f86f42d48b464e54109375a036572cde
      https://github.com/WebKit/WebKit/commit/312e1f95f86f42d48b464e54109375a036572cde
  Author: Pascoe <pascoe at apple.com>
  Date:   2025-01-31 (Fri, 31 Jan 2025)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/fast/events/ios/single-tap-verify-user-gesture-expected.txt
    A LayoutTests/fast/events/ios/single-tap-verify-user-gesture.html
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebKit/Shared/WebEventConversion.cpp
    M Source/WebKit/UIProcess/API/APINavigationAction.h
    M Source/WebKit/UIProcess/API/C/WKNavigationActionRef.cpp
    M Source/WebKit/UIProcess/API/C/WKNavigationActionRef.h
    M Source/WebKit/UIProcess/API/C/WKPreferences.cpp
    M Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Tools/WebKitTestRunner/TestController.cpp
    M Tools/WebKitTestRunner/TestOptions.cpp

  Log Message:
  -----------
  Pass along authorization token for touch events
https://bugs.webkit.org/show_bug.cgi?id=286775
rdar://problem/143917525

Reviewed by Charlie Wolfe.

We pass along authorization tokens for mouse and keyboard events for later verifying in the UI process, we should do the same for touch events.

I have added a layout test to exercise this behavior. This also requires an internal change that is related in the radar.

* LayoutTests/fast/events/ios/single-tap-verify-user-gesture-expected.txt: Added.
* LayoutTests/fast/events/ios/single-tap-verify-user-gesture.html: Added.
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent):
* Source/WebKit/Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent):
* Source/WebKit/UIProcess/API/APINavigationAction.h:
* Source/WebKit/UIProcess/API/C/WKNavigationActionRef.cpp:
(WKNavigationActionHasUnconsumedUserGesture):
* Source/WebKit/UIProcess/API/C/WKNavigationActionRef.h:
* Source/WebKit/UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesGetVerifyUserGestureInUIProcessEnabled):
* Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sendPreventableTouchEvent):
(WebKit::WebPageProxy::sendUnpreventableTouchEvent):
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::createOtherPlatformWebView):

Canonical link: https://commits.webkit.org/289612@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list