[webkit-changes] [WebKit/WebKit] 36fcd8: [macOS] AirPods mute gesture should also mute camera
youennf
noreply at github.com
Fri Jan 31 00:45:24 PST 2025
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 36fcd821004b0f9b80230dc87801370b2e85a3e9
https://github.com/WebKit/WebKit/commit/36fcd821004b0f9b80230dc87801370b2e85a3e9
Author: Youenn Fablet <youenn at apple.com>
Date: 2025-01-31 (Fri, 31 Jan 2025)
Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
Log Message:
-----------
[macOS] AirPods mute gesture should also mute camera
rdar://143146966
https://bugs.webkit.org/show_bug.cgi?id=286765
Reviewed by Jean-Yves Avenard.
On macOS, when muting only AirPods by AirPods gesture, OS indicators would not show whether microphone is muted or unmuted.
Only the chime would allow the user to know this.
As a short term fix, we now mute other captures as well as microphone (and unmute similarly).
This makes the AirPods gesture more similar to Safari mute UI.
We only update the desired web app capture state for microphone so that pinching the AirPods would not unmute camera in case the web application asked to mute the camera.
In addition to that, this patch fixes two issues:
- The computation of the last capturing microphone page was not always right. We are now computing based on the last web page report coming through WebPageProxy::updatePlayingMediaDidChange.
- We make sure when unmuting through AirPods to mute other web pages as our code in WebPageProxy::setMuted is not covering all cases in that case.
Manually tested.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setMuted):
(WebKit::WebPageProxy::microphoneMuteStatusChanged):
(WebKit::WebPageProxy::updatePlayingMediaDidChange):
Canonical link: https://commits.webkit.org/289600@main
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list