[webkit-changes] [WebKit/WebKit] 6f8cbc: Move GridAxis and GridTrackSizingDirection convers...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f8cbcc29a10b3911035756f9ce807a8f591c3f7
      https://github.com/WebKit/WebKit/commit/6f8cbcc29a10b3911035756f9ce807a8f591c3f7
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2025-01-30 (Thu, 30 Jan 2025)

  Changed paths:
    M Source/WebCore/rendering/GridLayoutFunctions.cpp
    M Source/WebCore/rendering/GridLayoutFunctions.h
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp

  Log Message:
  -----------
  Move GridAxis and GridTrackSizingDirection conversion helpers to GridTrackSizingDirection.
https://bugs.webkit.org/show_bug.cgi?id=286718
rdar://problem/143854174

Reviewed by Vitor Roriz.

As a precursor to some cleanup (removing the GridAxis enum), these
helpers will need to be non-static since we will need them in different
translation units. We can use GridLayoutFunctions as a home for them to
live next to other miscellaneous helper functions.

* Source/WebCore/rendering/GridLayoutFunctions.cpp:
(WebCore::GridLayoutFunctions::gridAxisForDirection):
(WebCore::GridLayoutFunctions::gridDirectionForAxis):
* Source/WebCore/rendering/GridLayoutFunctions.h:
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::isIntrinsicSizedGridArea const):
(WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForGridItem const):
(WebCore::GridTrackSizingAlgorithmStrategy::minContentContributionForGridItem const):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentContributionForGridItem const):
(WebCore::GridTrackSizingAlgorithmStrategy::minContributionForGridItem const):
(WebCore::GridTrackSizingAlgorithm::updateBaselineAlignmentContext):
(WebCore::GridTrackSizingAlgorithm::baselineOffsetForGridItem const):
(WebCore::GridTrackSizingAlgorithm::computeBaselineAlignmentContext):
(WebCore::gridAxisForDirection): Deleted.
(WebCore::gridDirectionForAxis): Deleted.

Canonical link: https://commits.webkit.org/289571@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications