[webkit-changes] [WebKit/WebKit] bc1ade: rdar://141787428 (Screen sharing pause button does...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc1adebed36b72d32614972ce0d59ade6c68ccc3
      https://github.com/WebKit/WebKit/commit/bc1adebed36b72d32614972ce0d59ade6c68ccc3
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2025-01-30 (Thu, 30 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/C/WKPage.cpp
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm

  Log Message:
  -----------
  rdar://141787428 (Screen sharing pause button does not pause)

Reviewed by Eric Carlson.

After https://github.com/WebKit/WebKit/commit/a9b4b55, WebCore is only muting window capture using MediaProducerMutedState::WindowCaptureIsMuted.
But WKPage SPI was only setting MediaProducerMutedState::ScreenCaptureIsMuted when trying to mute screen share.
We would then end up muting only screen tracks and not window tracks.
We update WKPage SPI and alos WKWebView SPI to also handle MediaProducerMutedState::WindowCaptureIsMuted and MediaProducerMutedState::SystemAudioCaptureIsMuted.

Manually tested and covered by updated test.

* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageSetMuted):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setPageMuted:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm:
(TestWebKitAPI::TEST(WebKit2, GetDisplayMediaWindowAndScreenPrompt)):

Originally-landed-as: 8da7b03ceb9e. rdar://143592356
Canonical link: https://commits.webkit.org/289565@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications