[webkit-changes] [WebKit/WebKit] 9524c2: [WGSL] Using UINT_MAX for binding triggers a RELEA...

Tadeu Zagallo noreply at github.com
Thu Jan 30 10:30:15 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9524c237534b6c009f577d1bfdaaf9842b195c7d
      https://github.com/WebKit/WebKit/commit/9524c237534b6c009f577d1bfdaaf9842b195c7d
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2025-01-30 (Thu, 30 Jan 2025)

  Changed paths:
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
    A Source/WebGPU/WGSL/tests/valid/binding-uint-max.wgsl

  Log Message:
  -----------
  [WGSL] Using UINT_MAX for binding triggers a RELEASE_ASSERT
https://bugs.webkit.org/show_bug.cgi?id=286695
rdar://143741471

Reviewed by Mike Wyrzykowski.

The `binding` value was used as the key to a HashMap, but the key had type `unsigned`
and `UINT_MAX` was used as the deleted value, so using `@binding(UINT_MAX)` triggered
a release assert in the HashMap.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
* Source/WebGPU/WGSL/tests/valid/binding-uint-max.wgsl: Added.

Canonical link: https://commits.webkit.org/289563@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list