[webkit-changes] [WebKit/WebKit] 5c0ff0: Reduce use of CSSCalcTree.h and CalculationTree.h ...

Thu Jan 30 08:42:47 PST 2025

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c0ff0cb989fa04a1ee848c39073574024d91ae3
      https://github.com/WebKit/WebKit/commit/5c0ff0cb989fa04a1ee848c39073574024d91ae3
  Author: Sam Weinig <sam at webkit.org>
  Date:   2025-01-30 (Thu, 30 Jan 2025)

  Changed paths:
    M Source/WTF/wtf/StdLibExtras.h
    M Source/WebCore/Headers.cmake
    M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/css/calc/CSSCalcTree+CalculationValue.cpp
    M Source/WebCore/css/calc/CSSCalcTree+Copy.cpp
    M Source/WebCore/css/calc/CSSCalcTree+Copy.h
    M Source/WebCore/css/calc/CSSCalcTree+Evaluation.cpp
    M Source/WebCore/css/calc/CSSCalcTree+Evaluation.h
    A Source/WebCore/css/calc/CSSCalcTree+Mappings.h
    M Source/WebCore/css/calc/CSSCalcTree+Parser.cpp
    M Source/WebCore/css/calc/CSSCalcTree+Parser.h
    M Source/WebCore/css/calc/CSSCalcTree+Serialization.cpp
    M Source/WebCore/css/calc/CSSCalcTree+Serialization.h
    M Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp
    M Source/WebCore/css/calc/CSSCalcTree+Simplification.h
    M Source/WebCore/css/calc/CSSCalcTree.cpp
    M Source/WebCore/css/calc/CSSCalcTree.h
    M Source/WebCore/css/calc/CSSCalcValue.cpp
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+CSSPrimitiveValueResolver.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+MetaConsumerDefinitions.h
    M Source/WebCore/css/query/MediaQueryParser.h
    M Source/WebCore/css/typedom/CSSNumericValue.cpp
    M Source/WebCore/css/typedom/CSSNumericValue.h
    M Source/WebCore/css/typedom/CSSUnitValue.cpp
    M Source/WebCore/css/typedom/numeric/CSSMathClamp.cpp
    M Source/WebCore/css/typedom/numeric/CSSMathInvert.cpp
    M Source/WebCore/css/typedom/numeric/CSSMathMax.cpp
    M Source/WebCore/css/typedom/numeric/CSSMathMin.cpp
    M Source/WebCore/css/typedom/numeric/CSSMathNegate.cpp
    M Source/WebCore/css/typedom/numeric/CSSMathProduct.cpp
    M Source/WebCore/css/typedom/numeric/CSSMathSum.cpp
    M Source/WebCore/css/typedom/numeric/CSSMathValue.cpp
    M Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+EvaluateCalc.h
    M Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes.h
    M Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.cpp
    M Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.h
    M Source/WebCore/platform/calc/CalculationOperator.h
    A Source/WebCore/platform/calc/CalculationRange.h
    M Source/WebCore/platform/calc/CalculationTree+Evaluation.cpp
    M Source/WebCore/platform/calc/CalculationTree+Evaluation.h
    M Source/WebCore/platform/calc/CalculationTree.cpp
    M Source/WebCore/platform/calc/CalculationTree.h
    M Source/WebCore/platform/calc/CalculationValue.cpp
    M Source/WebCore/platform/calc/CalculationValue.h
    M Source/WebCore/style/StyleBuilderState.cpp
    M Source/WebCore/style/values/primitives/StylePosition.h
    M Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Blending.h
    M Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Calculation.h
    M Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Conversions.cpp
    M Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Conversions.h
    M Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Evaluation.h
    M Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes.h
    A Source/WebCore/style/values/primitives/StyleUnevaluatedCalculation.cpp
    M Source/WebCore/style/values/primitives/StyleUnevaluatedCalculation.h

  Log Message:
  -----------
  Reduce use of CSSCalcTree.h and CalculationTree.h in header files
https://bugs.webkit.org/show_bug.cgi?id=286514

Reviewed by Antti Koivisto.

Makes CSSCalc::Child, CSSCalc::ChildOrNone and CSSCalc::Children,
and Calculation counterparts, forward declarable by wrapping the
complex definitions in structs. This also reduces the number of
times some template types have to be instantiated.

Additionally moves mappings of CSSCalcTree to/from CalculationTree
out of CSSCalcTree.h and into its own header. That allows removing
inclusion of CalculationTree.h from CSSCalcTree.h, cutting down on
more include bloat.

With these types now forward declarable, replace unnecessary
inclusions of CSSCalcTree.h and CalculationTree.h with forward
declarations in headers.

* Source/WTF/wtf/StdLibExtras.h:
Replace strict const reference requirement with a universal reference
to allow switching on non-const variant-likes.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/calc/CSSCalcTree+CalculationValue.cpp:
* Source/WebCore/css/calc/CSSCalcTree+Copy.cpp:
* Source/WebCore/css/calc/CSSCalcTree+Copy.h:
* Source/WebCore/css/calc/CSSCalcTree+Evaluation.cpp:
* Source/WebCore/css/calc/CSSCalcTree+Evaluation.h:
* Source/WebCore/css/calc/CSSCalcTree+Mappings.h: Added.
* Source/WebCore/css/calc/CSSCalcTree+Parser.cpp:
* Source/WebCore/css/calc/CSSCalcTree+Parser.h:
* Source/WebCore/css/calc/CSSCalcTree+Serialization.h:
* Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp:
* Source/WebCore/css/calc/CSSCalcTree+Simplification.h:
* Source/WebCore/css/calc/CSSCalcTree.cpp:
* Source/WebCore/css/calc/CSSCalcTree.h:
* Source/WebCore/css/calc/CSSCalcValue.cpp:
* Source/WebCore/css/query/MediaQueryParser.h:
* Source/WebCore/css/typedom/CSSNumericValue.cpp:
* Source/WebCore/css/typedom/CSSNumericValue.h:
* Source/WebCore/css/typedom/CSSUnitValue.cpp:
* Source/WebCore/css/typedom/numeric/CSSMathClamp.cpp:
* Source/WebCore/css/typedom/numeric/CSSMathInvert.cpp:
* Source/WebCore/css/typedom/numeric/CSSMathMax.cpp:
* Source/WebCore/css/typedom/numeric/CSSMathMin.cpp:
* Source/WebCore/css/typedom/numeric/CSSMathNegate.cpp:
* Source/WebCore/css/typedom/numeric/CSSMathProduct.cpp:
* Source/WebCore/css/typedom/numeric/CSSMathSum.cpp:
* Source/WebCore/css/typedom/numeric/CSSMathValue.cpp:
* Source/WebCore/platform/calc/CalculationOperator.h:
* Source/WebCore/platform/calc/CalculationRange.h: Copied from Source/WebCore/platform/calc/CalculationTree+Evaluation.h.
* Source/WebCore/platform/calc/CalculationTree+Evaluation.cpp:
* Source/WebCore/platform/calc/CalculationTree+Evaluation.h:
* Source/WebCore/platform/calc/CalculationTree.cpp:
* Source/WebCore/platform/calc/CalculationTree.h:
* Source/WebCore/platform/calc/CalculationValue.cpp:
* Source/WebCore/platform/calc/CalculationValue.h:
* Source/WebCore/style/values/primitives/StylePosition.h:
* Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Conversions.h:
* Source/WebCore/style/values/primitives/StyleUnevaluatedCalculation.h:

Canonical link: https://commits.webkit.org/289559@main

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications