[webkit-changes] [WebKit/WebKit] 591d8c: [ANGLE] Add envvar to allow gating ASSERTs at runtime

[Zak Ridouh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 591d8cca0024ecb5403b2baba14abe1f160ad6b0
      https://github.com/WebKit/WebKit/commit/591d8cca0024ecb5403b2baba14abe1f160ad6b0
  Author: Zak Ridouh <zakr at apple.com>
  Date:   2025-01-29 (Wed, 29 Jan 2025)

  Changed paths:
    M Source/ThirdParty/ANGLE/src/common/debug.cpp
    M Source/ThirdParty/ANGLE/src/common/log_utils.h

  Log Message:
  -----------
  [ANGLE] Add envvar to allow gating ASSERTs at runtime
https://bugs.webkit.org/show_bug.cgi?id=286591
rdar://143716846

Reviewed by Kimmo Kinnunen.

Add a `AreAssertionsEnabled()` function to `log_utils.h` to check a
runtime envvar once, and cache said value.This function is defined in
`common/debug.cpp`. This will allow us to modulate the ASSERTs crashing
the process regardless of how the ANGLE build was done.

The env var gating this is `ANGLE_DISABLE_ASSERTS`, so setting it to 1
will turn off asserts.

Additionally, the function is gated behind the `ANGLE_ENABLE_ASSERTS`
guard, so this will have no impact on production builds.

* Source/ThirdParty/ANGLE/src/common/debug.cpp:
(AreAssertionsEnabled):
* Source/ThirdParty/ANGLE/src/common/log_utils.h:

Canonical link: https://commits.webkit.org/289548@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications