[webkit-changes] [WebKit/WebKit] aab2b2: Incremental PDF loading code should build on iOS f...

Abrar Rahman Protyasha noreply at github.com
Wed Jan 29 17:32:31 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aab2b2258525f0d9ab9a188fbf45ad9c3f7e600b
      https://github.com/WebKit/WebKit/commit/aab2b2258525f0d9ab9a188fbf45ad9c3f7e600b
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2025-01-29 (Wed, 29 Jan 2025)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h
    M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations

  Log Message:
  -----------
  Incremental PDF loading code should build on iOS family
https://bugs.webkit.org/show_bug.cgi?id=286569
rdar://143686579

Reviewed by Megan Gardner and Wenson Hsieh.

This patch sets HAVE_INCREMENTAL_PDF_APIS for PLATFORM(IOS_FAMILY),
which allows incremental PDF loading code to build on the iOS family.
Note that all requisite CoreGraphics and PDFKit interfaces are available
on iOS already.

We write this patch in anticipation of webkit.org/b/286549, which tracks
_enablement_ of the incremental PDF loading behavior on iOS.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h:

Move `-[PDFDocument resetFormFields:]` out into an existing category for
annotations. Also, introduce an IncrementalLoading category for relevant
PDFDocument methods.

Furthermore, given these methods have long existed in internal SDKs, we
move the forward declarations inside `!USE(APPLE_INTERNAL_SDK)`,
allowing internal builds to pick up the signatures from PDFDocumentPriv.

* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:

Canonical link: https://commits.webkit.org/289535@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list