[webkit-changes] [WebKit/WebKit] 6f7da1: WritingTools.ProofreadingAcceptReject API test is ...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f7da1ea96ee43f2d39032af5e4a558951b57cbc
      https://github.com/WebKit/WebKit/commit/6f7da1ea96ee43f2d39032af5e4a558951b57cbc
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2025-01-29 (Wed, 29 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceReplacementTextEffectCoordinator.swift
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm

  Log Message:
  -----------
  WritingTools.ProofreadingAcceptReject API test is failing
https://bugs.webkit.org/show_bug.cgi?id=286606
rdar://143731399

Reviewed by Abrar Rahman Protyasha.

Update the selection restoration logic when a Writing Tools session ends to adhere to the correct behavior,
as described in the inline comments.

Also update the hard-coded delay in the test file to ensure that the animation is actually fully complete.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView didEndWritingToolsSession:accepted:]):
* Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceReplacementTextEffectCoordinator.swift:
(WKIntelligenceReplacementTextEffectCoordinator.replacementEffectDidComplete(_:)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(-[WritingToolsWKWebView waitForProofreadingSuggestionsToBeReplaced]):

Canonical link: https://commits.webkit.org/289525@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications