[webkit-changes] [WebKit/WebKit] 5ab04d: [scroll-animations] Have ScrollTimeline hold a Sty...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5ab04d6e08be21da84cf0cdc63115faa7702e99d
      https://github.com/WebKit/WebKit/commit/5ab04d6e08be21da84cf0cdc63115faa7702e99d
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2025-01-29 (Wed, 29 Jan 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/pseudo-on-scroller-expected.txt
    M Source/WebCore/animation/AnimationTimelinesController.cpp
    M Source/WebCore/animation/AnimationTimelinesController.h
    M Source/WebCore/animation/CSSAnimation.cpp
    M Source/WebCore/animation/ScrollTimeline.cpp
    M Source/WebCore/animation/ScrollTimeline.h
    M Source/WebCore/style/Styleable.h

  Log Message:
  -----------
  [scroll-animations] Have ScrollTimeline hold a Styleable source
https://bugs.webkit.org/show_bug.cgi?id=286504
rdar://143590723

Reviewed by Tim Nguyen.

To handle ScrollTimelines associated with pseudo elements, have ScrollTimeline hold a
Styleable source. This will need a follow up for ViewTimeline code as well as the named
timeline code on AnimationTimelinesController.

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/pseudo-on-scroller-expected.txt:
* Source/WebCore/animation/AnimationTimelinesController.cpp:
(WebCore::AnimationTimelinesController::registerNamedScrollTimeline):
* Source/WebCore/animation/AnimationTimelinesController.h:
* Source/WebCore/animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::syncStyleOriginatedTimeline):
* Source/WebCore/animation/ScrollTimeline.cpp:
(WebCore::ScrollTimeline::source const):
(WebCore::ScrollTimeline::setSource):
(WebCore::ScrollTimeline::controller const):
(WebCore::ScrollTimeline::documentWillUpdateAnimationsAndSendEvents):
(WebCore::ScrollTimeline::animationTimingDidChange):
* Source/WebCore/animation/ScrollTimeline.h:
* Source/WebCore/animation/WebAnimation.h:
* Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp:
* Source/WebCore/platform/animation/AcceleratedEffect.cpp:
* Source/WebCore/style/Styleable.cpp:
(WebCore::Styleable::applyKeyframeEffects const):
* Source/WebCore/style/Styleable.h:
(WebCore::WeakStyleable::operator== const):
(WebCore::WeakStyleable::WeakStyleable):
(WebCore::WeakStyleable::element const):
(WebCore::WeakStyleable::pseudoElementIdentifier const):
(WebCore::WeakStyleable::updateElement):
(WebCore::Styleable::applyKeyframeEffects const): Deleted.

Canonical link: https://commits.webkit.org/289523@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications