[webkit-changes] [WebKit/WebKit] 1de35d: [Skia][Cairo] convertImagePixels copies wrongly if...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1de35d8ca5de3b5707f2b0b23367af05e32327fe
      https://github.com/WebKit/WebKit/commit/1de35d8ca5de3b5707f2b0b23367af05e32327fe
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2025-01-29 (Wed, 29 Jan 2025)

  Changed paths:
    M Source/WebCore/platform/graphics/PixelBufferConversion.cpp
    M Source/WebCore/platform/graphics/PixelBufferConversion.h
    M Tools/TestWebKitAPI/CMakeLists.txt
    A Tools/TestWebKitAPI/Tests/WebCore/PixelBufferConversionTests.cpp

  Log Message:
  -----------
  [Skia][Cairo] convertImagePixels copies wrongly if no pixel conversion is needed and bytesPerRow are different for source and destination
https://bugs.webkit.org/show_bug.cgi?id=286664

Reviewed by Sam Weinig.

<https://commits.webkit.org/241230@main> added a fast code path of
convertImagePixels for Cairo port in case of no pixel conversion was
needed. However, it didn't take bytesPerRow and destinationSize into
account. It didn't work as expected.

<https://commits.webkit.org/277802@main> added a same code for Skia.

* Source/WebCore/platform/graphics/PixelBufferConversion.cpp:
(WebCore::copyImagePixels):
(WebCore::convertImagePixels):
* Source/WebCore/platform/graphics/PixelBufferConversion.h:
* Tools/TestWebKitAPI/CMakeLists.txt:
* Tools/TestWebKitAPI/Tests/WebCore/PixelBufferConversionTests.cpp: Added.
(TestWebKitAPI::TEST(PixelBufferConversionTests, convertImagePixels)):
(TestWebKitAPI::TEST(PixelBufferConversionTests, convertImagePixels2)):

Canonical link: https://commits.webkit.org/289520@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications