[webkit-changes] [WebKit/WebKit] fefb53: [WebGPU] Abandoned or failed command buffers can w...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fefb539ed6447b7df288366d26d52813e7a693e9
      https://github.com/WebKit/WebKit/commit/fefb539ed6447b7df288366d26d52813e7a693e9
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2025-01-29 (Wed, 29 Jan 2025)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/fuzz-286578-expected.txt
    A LayoutTests/fast/webgpu/nocrash/fuzz-286578.html
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] Abandoned or failed command buffers can workaround some validation
https://bugs.webkit.org/show_bug.cgi?id=286578
rdar://143628699

Reviewed by Cameron McCormack.

We need to check for status == completed prior to assuming the result
in the auxillary buffer contains reliable information.

For instance, a command buffer which was dropped and had a zero ref
count could trigger the completion handler to run without the work
ever being submitted to the MTLCommandQueue.

* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::clampIndexBufferToValidValues):
(WebGPU::checkForIndirectDrawDeviceLost):
(WebGPU::RenderPassEncoder::executeBundles):

* LayoutTests/fast/webgpu/nocrash/fuzz-286578-expected.txt
* LayoutTests/fast/webgpu/nocrash/fuzz-286578.html
Add regression test.

Canonical link: https://commits.webkit.org/289519@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications