[webkit-changes] [WebKit/WebKit] 3f975a: Node::normalize() can overflow destination string, ...

Commit Queue noreply at github.com
Wed Jan 29 12:48:14 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f975ad6e201b37a19f7ed0af4473872caf4898d
      https://github.com/WebKit/WebKit/commit/3f975ad6e201b37a19f7ed0af4473872caf4898d
  Author: Pedro Varangot <pvarangot at apple.com>
  Date:   2025-01-29 (Wed, 29 Jan 2025)

  Changed paths:
    A LayoutTests/fast/dom/normalize-doesnt-check-string-length-expected.txt
    A LayoutTests/fast/dom/normalize-doesnt-check-string-length.html
    M Source/WebCore/dom/Node.cpp
    M Source/WebCore/dom/Node.h

  Log Message:
  -----------
  Node::normalize() can overflow destination string, resulting in an assert
rdar://141028000
https://bugs.webkit.org/show_bug.cgi?id=286451

Reviewed by Chris Dumez, Ryosuke Niwa, and Alexey Proskuryakov.

This fixes the bug by raising an exception if the next node overflows the accumulated string.

* LayoutTests/fast/dom/normalize-doesnt-check-string-length-expected.txt:
* LayoutTests/fast/dom/normalize-doesnt-check-string-length.html:
* Source/WebCore/dom/Node.cpp:
(WebCore::Node::normalize):
* Source/WebCore/dom/Node.h:

Canonical link: https://commits.webkit.org/289518@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list