[webkit-changes] [WebKit/WebKit] 3a8858: REGRESSION(286883 at main): ASSERT NOT REACHED in Web...

Commit Queue noreply at github.com
Wed Jan 29 08:48:21 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3a885897a634abba8d8c80b086bd8eb0fe1ede39
      https://github.com/WebKit/WebKit/commit/3a885897a634abba8d8c80b086bd8eb0fe1ede39
  Author: Pedro Varangot <pvarangot at apple.com>
  Date:   2025-01-29 (Wed, 29 Jan 2025)

  Changed paths:
    M LayoutTests/ipc/cfnetwork-crashes-with-string-to-string-http-headers.html
    A LayoutTests/ipc/url-requestPriority-out-of-range-expected.txt
    A LayoutTests/ipc/url-requestPriority-out-of-range.html
    M Source/WebKit/Shared/Cocoa/CoreIPCNSURLRequest.mm

  Log Message:
  -----------
  REGRESSION(286883 at main): ASSERT NOT REACHED in WebCore::toResourceLoadPriority(CFURLRequestPriority)
rdar://140442183
https://bugs.webkit.org/show_bug.cgi?id=283596

Reviewed by Ryosuke Niwa.

This fixes the regression by setting a value for the priority that is within bounds, and prevents future asserts by clamping

* LayoutTests/ipc/cfnetwork-crashes-with-string-to-string-http-headers.html:
* LayoutTests/ipc/url-requestPriority-out-of-range-expected.txt: Added.
* LayoutTests/ipc/url-requestPriority-out-of-range.html: Copied from LayoutTests/ipc/cfnetwork-crashes-with-string-to-string-http-headers.html.
* Source/WebKit/Shared/Cocoa/CoreIPCNSURLRequest.mm:
(WebKit::CoreIPCNSURLRequest::toID const):

Canonical link: https://commits.webkit.org/289501@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list