[webkit-changes] [WebKit/WebKit] c9971b: Cherry-pick 287110 at main (0a214d0d9a28). https://bu...

[Said Abou-Hallawa]

  Branch: refs/heads/webkitglib/2.46
  Home:   https://github.com/WebKit/WebKit
  Commit: c9971bc8c40c93714c75c7a41ee6df9a7faa750a
      https://github.com/WebKit/WebKit/commit/c9971bc8c40c93714c75c7a41ee6df9a7faa750a
  Author: Devin Rousso <hi at devinrousso.com>
  Date:   2025-01-29 (Wed, 29 Jan 2025)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/GraphicsTabContentView.css

  Log Message:
  -----------
  Cherry-pick 287110 at main (0a214d0d9a28). https://bugs.webkit.org/show_bug.cgi?id=283735

    Web Inspector: Graphics: overview icon is not inverted in dark mode
    https://bugs.webkit.org/show_bug.cgi?id=283735

    Reviewed by Tim Nguyen.

    * Source/WebInspectorUI/UserInterface/Views/GraphicsTabContentView.css:
    (@media (prefers-color-scheme: dark) .content-view.tab.graphics .navigation-bar > .item .canvas-overview .icon): Renamed from `@media (prefers-color-scheme: dark) .content-view.tab.graphics .navigation-bar > .item .graphics-overview .icon`.
    This was likely a typo from 219987 at main.

    Canonical link: https://commits.webkit.org/287110@main

Canonical link: https://commits.webkit.org/282416.414@webkitglib/2.46


  Commit: c10ff3e06baf49346f0d14c4a5156f3ff2d6f73d
      https://github.com/WebKit/WebKit/commit/c10ff3e06baf49346f0d14c4a5156f3ff2d6f73d
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2025-01-29 (Wed, 29 Jan 2025)

  Changed paths:
    M Source/WebCore/bindings/js/JSAbortSignalCustom.cpp
    M Source/WebCore/dom/AbortSignal.h
    M Source/WebCore/page/Navigation.cpp

  Log Message:
  -----------
  Cherry-pick 286987 at main (dd0e9528e748). https://bugs.webkit.org/show_bug.cgi?id=281793

    REGRESSION (280616 at main?): [macOS Debug wk2] ASSERTION FAILED: m_wrapper in *WebCore::JSEventListener::ensureJSFunction(ScriptExecutionContext
    https://bugs.webkit.org/show_bug.cgi?id=281793
    rdar://138219837

    Reviewed by Ryosuke Niwa.

    The test was crashing because the AbortSignal's JS wrapper was destroyed
    by the time the navigation gets aborted and we attempt to dispatch an
    `abort` event on the AbortSignal object.

    The AbortSignal object has an `abort` event listener so one would expect
    the JS wrapper to be kept alive. However, the logic in
    JSAbortSignalOwner::isReachableFromOpaqueRoots() required both having
    an `abort` event listener and having source signals. Source signals only
    apply to "dependent" signals so it shouldn't apply here. Tweak this
    function to address the lifetime issue.

    * LayoutTests/platform/mac-wk2/TestExpectations:
    * Source/WebCore/bindings/js/JSAbortSignalCustom.cpp:
    (WebCore::JSAbortSignalOwner::isReachableFromOpaqueRoots):
    * Source/WebCore/dom/AbortSignal.h:
    * Source/WebCore/page/Navigation.cpp:
    (WebCore::Navigation::abortOngoingNavigation):

    Canonical link: https://commits.webkit.org/286987@main

Canonical link: https://commits.webkit.org/282416.415@webkitglib/2.46


  Commit: f7dc5a47830d0616ab1cb20b81b3b73a1c91f75b
      https://github.com/WebKit/WebKit/commit/f7dc5a47830d0616ab1cb20b81b3b73a1c91f75b
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2025-01-29 (Wed, 29 Jan 2025)

  Changed paths:
    M Source/WebCore/platform/graphics/Path.h
    M Source/WebCore/platform/graphics/PathSegmentData.cpp

  Log Message:
  -----------
  Cherry-pick 286618 at main (dae159bae231). https://bugs.webkit.org/show_bug.cgi?id=283127

    REGRESSION(265569 at main): Fix division by zero in calculating the boundingRect of a QuadraticCurve
    https://bugs.webkit.org/show_bug.cgi?id=283127
    rdar://139904014

    Reviewed by Simon Fraser.

    Avoid dividing by zero if the controlPoint is the mid-point of the currentPoint
    and the endPoint.

    * Source/WebCore/platform/graphics/Path.h:
    * Source/WebCore/platform/graphics/PathSegmentData.cpp:
    (WebCore::calculateQuadraticExtremity):
    * Tools/TestWebKitAPI/Tests/WebCore/PathTests.cpp:
    (TestWebKitAPI::TEST(Path, CurveBoundingRect)):

    Canonical link: https://commits.webkit.org/286618@main

Canonical link: https://commits.webkit.org/282416.416@webkitglib/2.46


  Commit: 4bbfd1c7be91d707ca94643ca0a311b88a0583e6
      https://github.com/WebKit/WebKit/commit/4bbfd1c7be91d707ca94643ca0a311b88a0583e6
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2025-01-29 (Wed, 29 Jan 2025)

  Changed paths:
    A LayoutTests/svg/custom/quadratic-path-in-tiled-layer-expected.html
    A LayoutTests/svg/custom/quadratic-path-in-tiled-layer.html
    M Source/WebCore/platform/graphics/PathSegmentData.cpp

  Log Message:
  -----------
  Cherry-pick 286550 at main (5eadead07f65). https://bugs.webkit.org/show_bug.cgi?id=279105

    REGRESSION(265569 at main): SVG paths can get clipped at tile boundaries
    https://bugs.webkit.org/show_bug.cgi?id=279105
    rdar://135280080

    Reviewed by Simon Fraser.

    When the distance between the current point and the end point of a cubic Bézier
    curve is split into three equal parts with the two control points, the slope of
    the curve can't be calculated from the derivative of the curve equation.

    But in this case, the curve has to be quadratic which means the t-coordinate of
    its vertex must be the mid-point between the current point and the end point.

    * LayoutTests/svg/custom/quadratic-path-in-tiled-layer-expected.html: Added.
    * LayoutTests/svg/custom/quadratic-path-in-tiled-layer.html: Added.
    * Source/WebCore/platform/graphics/PathSegmentData.cpp:
    (WebCore::calculateBezierExtremities):

    Canonical link: https://commits.webkit.org/286550@main

Canonical link: https://commits.webkit.org/282416.417@webkitglib/2.46


Compare: https://github.com/WebKit/WebKit/compare/c8b37e7361b3...4bbfd1c7be91

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications