[webkit-changes] [WebKit/WebKit] 62bec2: chriskirknielsen.com: Containing blocks not sizing...

Sammy Gill noreply at github.com
Tue Jan 28 21:46:55 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62bec285221794fed2fdfb5fdc561a6564edd22b
      https://github.com/WebKit/WebKit/commit/62bec285221794fed2fdfb5fdc561a6564edd22b
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2025-01-28 (Tue, 28 Jan 2025)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-caps-invalidation-container-sizing-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-caps-invalidation-container-sizing.html
    M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp

  Log Message:
  -----------
  chriskirknielsen.com: Containing blocks not sizing properly when font-variant-caps changes on content.
https://bugs.webkit.org/show_bug.cgi?id=285264
rdar://142212550

Reviewed by Alan Baradlay.

On a style change, we update the content characteristics of an inline
text box via updateContentCharacteristic, which may add the CanUseSimplifiedContentMeasuring
characteristic on certain pieces of content. We currently allow this
characteristic to be applied for all values of font-variant-caps, but
this is at odds with what we do in RenderText. We should match
RenderText by performing complex content measuring when we see these
values of font-variant-caps.

* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-caps-invalidation-container-sizing-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-variant-caps-invalidation-container-sizing.html: Added.
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::canUseSimplifiedTextMeasuring):

Canonical link: https://commits.webkit.org/289486@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list