[webkit-changes] [WebKit/WebKit] e99fbe: Various plugin unavailability codepaths in HTMLPlu...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e99fbe347168f2738d52ea51626ea37f27bb284e
      https://github.com/WebKit/WebKit/commit/e99fbe347168f2738d52ea51626ea37f27bb284e
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2025-01-28 (Tue, 28 Jan 2025)

  Changed paths:
    M Source/WebCore/html/HTMLPlugInElement.cpp
    M Source/WebCore/html/HTMLPlugInElement.h
    M Source/WebCore/rendering/RenderEmbeddedObject.cpp
    M Source/WebCore/rendering/RenderEmbeddedObject.h
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl

  Log Message:
  -----------
  Various plugin unavailability codepaths in HTMLPlugInElement/RenderEembeddedObject are unused
https://bugs.webkit.org/show_bug.cgi?id=286567
rdar://143686152

Reviewed by Anne van Kesteren and Tim Horton.

Following 243690 at main and 282972 at main, quite a few methods (and class
states) corresponding to plugin unavailability are unused. This PR
removes all this dead code.

* Source/WebCore/html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::setReplacement): Deleted.
(WebCore::HTMLPlugInElement::isReplacementObscured): Deleted.
* Source/WebCore/html/HTMLPlugInElement.h:
* Source/WebCore/rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
(WebCore::RenderEmbeddedObject::paintReplaced):
(WebCore::RenderEmbeddedObject::getCursor const):
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReasonWithDescription): Deleted.
(WebCore::RenderEmbeddedObject::setUnavailablePluginIndicatorIsHidden): Deleted.
(WebCore::RenderEmbeddedObject::unavailablePluginIndicatorBounds const): Deleted.
* Source/WebCore/rendering/RenderEmbeddedObject.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::isPluginUnavailabilityIndicatorObscured): Deleted.
(WebCore::Internals::unavailablePluginReplacementText): Deleted.
(WebCore::Internals::isPluginSnapshotted): Deleted.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/289485@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications