[webkit-changes] [WebKit/WebKit] 53ee54: "Offset out of range in span::subspan(offset, coun...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53ee544dee9b8fc6610d0ce70f23c673804bbd03
      https://github.com/WebKit/WebKit/commit/53ee544dee9b8fc6610d0ce70f23c673804bbd03
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2025-01-28 (Tue, 28 Jan 2025)

  Changed paths:
    M Source/WebCore/platform/graphics/PixelBufferConversion.cpp

  Log Message:
  -----------
  "Offset out of range in span::subspan(offset, count)" error under WebCore::convertImagePixelsUnaccelerated
https://bugs.webkit.org/show_bug.cgi?id=286338

Reviewed by Sam Weinig.

"Offset out of range in span::subspan(offset, count)" error was
happenning in WebCore::convertImagePixelsUnaccelerated with Windows
Debug CRT.

`skip(sourceRows, source.bytesPerRow)` was executed
`destinationSize.height()` times. However, the `skip(...)` can be
safely executed only `destinationSize.height() - 1` times.

Changed the code not to use `skip`.

* Source/WebCore/platform/graphics/PixelBufferConversion.cpp:
(WebCore::convertImagePixelsUnaccelerated):

Canonical link: https://commits.webkit.org/289484@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications