[webkit-changes] [WebKit/WebKit] 826f74: Allow specifying a ResolvedValueType for any CSS n...

Sam Weinig noreply at github.com
Tue Jan 28 19:58:58 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 826f74712a031178b2ebcb73ba1fa38de6192e97
      https://github.com/WebKit/WebKit/commit/826f74712a031178b2ebcb73ba1fa38de6192e97
  Author: Sam Weinig <sam at webkit.org>
  Date:   2025-01-28 (Tue, 28 Jan 2025)

  Changed paths:
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+AngleDefinitions.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+AnglePercentageDefinitions.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+FlexDefinitions.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+FrequencyDefinitions.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+LengthDefinitions.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+LengthPercentageDefinitions.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+NumberDefinitions.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+PercentageDefinitions.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+ResolutionDefinitions.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+TimeDefinitions.h
    M Source/WebCore/css/values/primitives/CSSPrimitiveNumericRaw.h
    M Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+Canonicalization.h
    M Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+Serialization.h
    M Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes.h
    M Source/WebCore/html/HTMLInputElement.cpp
    M Source/WebCore/style/values/images/StyleGradient.cpp
    M Source/WebCore/style/values/primitives/StylePosition.cpp
    M Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Blending.h
    M Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Calculation.h
    M Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Conversions.h
    M Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Evaluation.h
    M Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Logging.h
    M Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes.h
    M Source/WebCore/style/values/shapes/StyleRectFunction.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Tools/TestWebKitAPI/Tests/WebCore/StyleGradient.cpp

  Log Message:
  -----------
  Allow specifying a ResolvedValueType for any CSS numeric primitive
https://bugs.webkit.org/show_bug.cgi?id=286625

Reviewed by Antti Koivisto.

Allow specifying a ResolvedValueType for any CSS numeric primitive. This makes it
explicit that `LengthPercentage` resolves to float, rather than double, and allow
us to change that to something like LayoutUnit on a per-instance basis in the future.

This will also allow us to simplify CompactVariant by remove the alternative
representation functionality in a follow up.

Most of the change is piping the `V` template parameter around.

* Source/WebCore/css/parser/CSSPropertyParserConsumer+AngleDefinitions.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+AnglePercentageDefinitions.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+FlexDefinitions.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+FrequencyDefinitions.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+LengthDefinitions.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+LengthPercentageDefinitions.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+NumberDefinitions.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+PercentageDefinitions.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+ResolutionDefinitions.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+TimeDefinitions.h:
* Source/WebCore/css/values/primitives/CSSPrimitiveNumericRaw.h:
* Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+Canonicalization.h:
* Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+Serialization.h:
* Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes.h:
* Source/WebCore/style/values/images/StyleGradient.cpp:
* Source/WebCore/style/values/primitives/StylePosition.cpp:
* Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Blending.h:
* Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Calculation.h:
* Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Conversions.h:
* Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Evaluation.h:
* Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Logging.h:
* Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes.h:
* Source/WebCore/style/values/shapes/StyleRectFunction.cpp:

Canonical link: https://commits.webkit.org/289482@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list