[webkit-changes] [WebKit/WebKit] af11fc: TestWebKitAPI.WritingTools.PDFTextSelections is co...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af11fc7817a0dc43e8d50064979f5e1211ab847c
      https://github.com/WebKit/WebKit/commit/af11fc7817a0dc43e8d50064979f5e1211ab847c
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2025-01-28 (Tue, 28 Jan 2025)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm

  Log Message:
  -----------
  TestWebKitAPI.WritingTools.PDFTextSelections is consistently failing
https://bugs.webkit.org/show_bug.cgi?id=286650
rdar://143731070

Reviewed by Wenson Hsieh.

This failing API test would create a text selection and query the web
view about the current WritingTools behavior. However, in its current
form, since the plugin isn’t focused, the information we get (in this
test) about the text selection does not pertain to the plugin, actually.
As such, we don't get to report `WritingToolsBehaviorNone` as the
behavior.

Address this test failure by ensuring the plugin is focused before
trying to make a selection.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools, PDFTextSelections)):

Canonical link: https://commits.webkit.org/289475@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications