[webkit-changes] [WebKit/WebKit] 748d56: [Xcode] "Make Frameworks Symbolic Link" script pha...

[Elliott Williams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 748d56ebc1c895e39eccc5729155ba3af6bb7b8b
      https://github.com/WebKit/WebKit/commit/748d56ebc1c895e39eccc5729155ba3af6bb7b8b
  Author: Elliott Williams <emw at apple.com>
  Date:   2025-01-28 (Tue, 28 Jan 2025)

  Changed paths:
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  [Xcode] "Make Frameworks Symbolic Link" script phase causing "error: Multiple commands produce WebKit.framework/Frameworks"
https://bugs.webkit.org/show_bug.cgi?id=286370
rdar://143143759

Reviewed by Geoffrey Garen.

AFAICT, this symlink is needed to form the WebKit.framework umbrella
structure. Clients of WebCore/WebKitLegacy (such as test tools) may load
from WebKit.framework/Framework/... paths directly, without going
through the Versions/A/ directory.

Modern Xcodes create this symlink automatically, and have started
diagnosing this as a duplicate output. However, we still support
building on older Xcodes which do not create it. It doesn't appear to be
needed in debug-style builds, since dyld and tooling loads framework
from a flat build directory structure.

Make the script phase declare zero dependencies (so the build system
does not detect the problem) and install-only (so that it does not
re-run on every incremental build). As a drive-by, fix an equivalent
script phase in WebCore to behave the same way. It was not causing
issues because there was a typo in its declared output dependency.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/289471@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications