[webkit-changes] [WebKit/WebKit] cb4b20: Versioning.

Tue Jan 28 11:22:50 PST 2025

  Branch: refs/heads/safari-7620.2.4.11-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: cb4b2065ce8b3924fcce2ad174ed1c2fdb514711
      https://github.com/WebKit/WebKit/commit/cb4b2065ce8b3924fcce2ad174ed1c2fdb514711
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2025-01-06 (Mon, 06 Jan 2025)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7620.2.4.11.2

Canonical link: https://commits.webkit.org/283286.605@safari-7620.2.4.11-branch

  Commit: b5f0dbbce43f76bc1463fc142a841e34a4742062
      https://github.com/WebKit/WebKit/commit/b5f0dbbce43f76bc1463fc142a841e34a4742062
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2025-01-06 (Mon, 06 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/C/WKPage.cpp
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm

  Log Message:
  -----------
  Cherry-pick 8da7b03ceb9e. rdar://141787428

    rdar://141787428 (J416s/24D34: Screen sharing pause button does not pause)

    Reviewed by Eric Carlson.

    After https://github.com/WebKit/WebKit/commit/a9b4b55, WebCore is only muting window capture using MediaProducerMutedState::WindowCaptureIsMuted.
    But WKPage SPI was only setting MediaProducerMutedState::ScreenCaptureIsMuted when trying to mute screen share.
    We would then end up muting only screen tracks and not window tracks.
    We update WKPage SPI and alos WKWebView SPI to also handle MediaProducerMutedState::WindowCaptureIsMuted and MediaProducerMutedState::SystemAudioCaptureIsMuted.

    Manually tested and covered by updated test.

    * Source/WebKit/UIProcess/API/C/WKPage.cpp:
    (WKPageSetMuted):
    * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
    (-[WKWebView _setPageMuted:]):
    * Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm:
    (TestWebKitAPI::TEST(WebKit2, GetDisplayMediaWindowAndScreenPrompt)):

    Canonical link: https://commits.webkit.org/283286.604@safari-7620-branch

Canonical link: https://commits.webkit.org/283286.606@safari-7620.2.4.11-branch

  Commit: 8cc3142be57df37ec034321c284711a6ade4fb13
      https://github.com/WebKit/WebKit/commit/8cc3142be57df37ec034321c284711a6ade4fb13
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2025-01-07 (Tue, 07 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/C/WKPage.cpp
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm

  Log Message:
  -----------
  Revert 8da7b03ceb9e. rdar://141787428

This reverts commit b5f0dbbce43f76bc1463fc142a841e34a4742062.

Canonical link: https://commits.webkit.org/283286.607@safari-7620.2.4.11-branch

  Commit: 0d687c61c6ec5cab57fbe50e7931be00e692c3d5
      https://github.com/WebKit/WebKit/commit/0d687c61c6ec5cab57fbe50e7931be00e692c3d5
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2025-01-07 (Tue, 07 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/C/WKPage.cpp
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm

  Log Message:
  -----------
  Cherry-pick 8da7b03ceb9e. rdar://141787428

    rdar://141787428 (J416s/24D34: Screen sharing pause button does not pause)

    Reviewed by Eric Carlson.

    After https://github.com/WebKit/WebKit/commit/a9b4b55, WebCore is only muting window capture using MediaProducerMutedState::WindowCaptureIsMuted.
    But WKPage SPI was only setting MediaProducerMutedState::ScreenCaptureIsMuted when trying to mute screen share.
    We would then end up muting only screen tracks and not window tracks.
    We update WKPage SPI and alos WKWebView SPI to also handle MediaProducerMutedState::WindowCaptureIsMuted and MediaProducerMutedState::SystemAudioCaptureIsMuted.

    Manually tested and covered by updated test.

    * Source/WebKit/UIProcess/API/C/WKPage.cpp:
    (WKPageSetMuted):
    * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
    (-[WKWebView _setPageMuted:]):
    * Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm:
    (TestWebKitAPI::TEST(WebKit2, GetDisplayMediaWindowAndScreenPrompt)):

    Canonical link: https://commits.webkit.org/283286.604@safari-7620-branch

Canonical link: https://commits.webkit.org/283286.608@safari-7620.2.4.11-branch

  Commit: 4cf9e05783f12604e209140f90c09ad7c04ca386
      https://github.com/WebKit/WebKit/commit/4cf9e05783f12604e209140f90c09ad7c04ca386
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2025-01-07 (Tue, 07 Jan 2025)

  Changed paths:
    M Source/WTF/wtf/CrossThreadTask.h
    M Source/WTF/wtf/TypeTraits.h

  Log Message:
  -----------
  Cherry-pick 0a6d878611ce. rdar://141997895

    Web content process crash in WebCore::Event::~Event
    rdar://141997895

    Reviewed by Chris Dumez.

    rdar://139782420 made IDBDatabase subclass ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr. However,
    createCrossThreadTask() does not capture RefPtr for derived classes of ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr.
    To fix it, make sure createCrossThreadTask() creates RefPtr when ref() member function is available.

    * Source/WTF/wtf/CrossThreadTask.h:
    (WTF::createCrossThreadTask):
    * Source/WTF/wtf/TypeTraits.h:

    Canonical link: https://commits.webkit.org/283286.605@safari-7620-branch

Canonical link: https://commits.webkit.org/283286.609@safari-7620.2.4.11-branch

  Commit: 3ff7650db4fe6e662e0680b43a993ed2c17f493d
      https://github.com/WebKit/WebKit/commit/3ff7650db4fe6e662e0680b43a993ed2c17f493d
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2025-01-07 (Tue, 07 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionDynamicScriptsCocoa.mm

  Log Message:
  -----------
  Cherry-pick 144dde143d3a. rdar://142452073

    Hang in +[NSString stringEncodingForData:encodingOptions:convertedString:usedLossyConversion:].
    https://webkit.org/b/285533
    rdar://142452073

    Reviewed by Brian Weinstein.

    Use WebCore::TextResourceDecoder instead of +[NSString stringEncodingForData:].
    Also cache the result so detection only happens once, and avoids disk access when
    an extension is executing the same script over and over in many tabs.

    * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
    (WebKit::WebExtension::resourceStringForPath): Use TextResourceDecoder.
    * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionDynamicScriptsCocoa.mm:
    (WebKit::WebExtensionDynamicScripts::sourcePairForResource): Cache the result.

    Canonical link: https://commits.webkit.org/283286.606@safari-7620-branch

Canonical link: https://commits.webkit.org/283286.610@safari-7620.2.4.11-branch

  Commit: ca528878a0b4602f784000d3149ce144568a4922
      https://github.com/WebKit/WebKit/commit/ca528878a0b4602f784000d3149ce144568a4922
  Author: Mohsin Qureshi <mohsinq at apple.com>
  Date:   2025-01-08 (Wed, 08 Jan 2025)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7620.2.4.10.3

Canonical link: https://commits.webkit.org/283286.611@safari-7620.2.4.11-branch

  Commit: 802c36ad14862dfbc14b6063f05484a22c8fc427
      https://github.com/WebKit/WebKit/commit/802c36ad14862dfbc14b6063f05484a22c8fc427
  Author: Nitin Mahendru <nitinmahendru at apple.com>
  Date:   2025-01-08 (Wed, 08 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp

  Log Message:
  -----------
  Cherry-pick 31b520ae23d1. rdar://142563834

    [WebAuthn] Log the msg size for Ctap Requests
    https://bugs.webkit.org/show_bug.cgi?id=285612
    rdar://142552801

    Reviewed by Pascoe.

    Add a log message in case we are about to send a request that we suspect will fail.

    * Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:
    (WebKit::CtapAuthenticator::makeCredential):
    (WebKit::CtapAuthenticator::getAssertion):

    Canonical link: https://commits.webkit.org/288604@main

  Commit: 45be197cc84c4a1f9f7d64d69b7f89f97d77072f
      https://github.com/WebKit/WebKit/commit/45be197cc84c4a1f9f7d64d69b7f89f97d77072f
  Author: Mohsin Qureshi <mohsinq at apple.com>
  Date:   2025-01-08 (Wed, 08 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp

  Log Message:
  -----------
  Revert 31b520ae23d1. rdar://142563834

This reverts commit 802c36ad14862dfbc14b6063f05484a22c8fc427.

  Commit: 041148b173b4d82627c39f63f4e225ac36e571a3
      https://github.com/WebKit/WebKit/commit/041148b173b4d82627c39f63f4e225ac36e571a3
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2025-01-08 (Wed, 08 Jan 2025)

  Changed paths:
    A JSTests/wasm/stress/array-element-creation.js
    A JSTests/wasm/stress/resources/array-element-creation.wasm
    M Source/JavaScriptCore/wasm/WasmOperations.cpp
    M Source/JavaScriptCore/wasm/WasmOperationsInlines.h
    M Source/JavaScriptCore/wasm/js/JSWebAssemblyArray.cpp
    M Source/JavaScriptCore/wasm/js/JSWebAssemblyArray.h
    M Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp
    M Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.h

  Log Message:
  -----------
  Cherry-pick ac2bd207812a. rdar://141144921

    [JSC] WasmGC Array is broken for GC
    https://bugs.webkit.org/show_bug.cgi?id=285580
    rdar://141144921

    Reviewed by Keith Miller.

    WasmGC Array is broken for GC in multiple ways. We carefully reviewed WasmGC
    Array implementation. We found many issues, and this patch fixes them.

    1. Doing GC while putting GC values in FixedVector. That's totally
       wrong. We fixed it by first creating WasmGC Array and modifying the
       contents later.
    2. arrayNewElem is always creating I64 array, which is broken. We should
       create a specified typed array.
    3. WasmGC Array copy implementation is using std::copy even for
       overlapping region. That's totally wrong, and it should use memmove.
       For GC-ref-types, we should use gcSafeMemmove.

    * JSTests/wasm/stress/array-element-creation.js: Added.
    * JSTests/wasm/stress/resources/array-element-creation.wasm: Added.
    * Source/JavaScriptCore/wasm/WasmOperations.cpp:
    (JSC::Wasm::JSC_DEFINE_NOEXCEPT_JIT_OPERATION):
    * Source/JavaScriptCore/wasm/WasmOperationsInlines.h:
    (JSC::Wasm::fillArray):
    (JSC::Wasm::arrayNew):
    (JSC::Wasm::copyElementsInReverse):
    (JSC::Wasm::arrayNewFixed):
    (JSC::Wasm::createArrayFromDataSegment):
    (JSC::Wasm::arrayNewData):
    (JSC::Wasm::arrayNewElem):
    (JSC::Wasm::arrayInitElem):
    (JSC::Wasm::arrayInitData):
    (JSC::Wasm::createArrayValue): Deleted.
    (JSC::Wasm::createArrayFromElementSegment): Deleted.
    * Source/JavaScriptCore/wasm/js/JSWebAssemblyArray.cpp:
    (JSC::JSWebAssemblyArray::JSWebAssemblyArray):
    (JSC::JSWebAssemblyArray::fill):
    (JSC::JSWebAssemblyArray::copy):
    (JSC::JSWebAssemblyArray::visitChildrenImpl):
    * Source/JavaScriptCore/wasm/js/JSWebAssemblyArray.h:
    * Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp:
    (JSC::JSWebAssemblyInstance::copyDataSegment):
    (JSC::JSWebAssemblyInstance::copyElementSegment):
    * Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.h:

    Canonical link: https://commits.webkit.org/283286.607@safari-7620-branch

  Commit: 0f26e4b6d0b277918458673c555dad6c6310d44c
      https://github.com/WebKit/WebKit/commit/0f26e4b6d0b277918458673c555dad6c6310d44c
  Author: Mohsin Qureshi <mohsinq at apple.com>
  Date:   2025-01-08 (Wed, 08 Jan 2025)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7620.2.4.11.3

Canonical link: https://commits.webkit.org/283286.615@safari-7620.2.4.11-branch

  Commit: 5b38ee4c56c0948eb62f680a59b0aa18eeee6e5e
      https://github.com/WebKit/WebKit/commit/5b38ee4c56c0948eb62f680a59b0aa18eeee6e5e
  Author: Mohsin Qureshi <mohsinq at apple.com>
  Date:   2025-01-10 (Fri, 10 Jan 2025)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7620.2.4.11.4

Canonical link: https://commits.webkit.org/283286.616@safari-7620.2.4.11-branch

  Commit: ce02f8f7b1b5243c3e69f5e74a72da19184124d9
      https://github.com/WebKit/WebKit/commit/ce02f8f7b1b5243c3e69f5e74a72da19184124d9
  Author: Mohsin Qureshi <mohsinq at apple.com>
  Date:   2025-01-10 (Fri, 10 Jan 2025)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7620.2.4.11.5

Canonical link: https://commits.webkit.org/283286.617@safari-7620.2.4.11-branch

  Commit: d2a4fe37e7063e6d4fd61ab2f84badc14c87981f
      https://github.com/WebKit/WebKit/commit/d2a4fe37e7063e6d4fd61ab2f84badc14c87981f
  Author: Yijia Huang <yijia_huang at apple.com>
  Date:   2025-01-10 (Fri, 10 Jan 2025)

  Changed paths:
    M Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp

  Log Message:
  -----------
  Cherry-pick d1ea32844028. rdar://142713278

    [WASM] Fix Memory Leaks in Wasm::Table for JSWebAssemblyInstance
    https://bugs.webkit.org/show_bug.cgi?id=285766
    rdar://142702955

    Reviewed by Yijia Huang.

    JSWebAssemblyInstance::setTable stores a reference to Wasm::Table
    in an array of raw Wasm::Table pointers by leaking the references.
    Although the array contains raw pointers, these pointers are still
    reference-counted. Therefore, JSWebAssemblyInstance should properly
    manage their lifecycles by releasing the references when the instance
    is about to be destroyed.

    * Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp:
    (JSC::JSWebAssemblyInstance::~JSWebAssemblyInstance):

Compare: https://github.com/WebKit/WebKit/compare/cb4b2065ce8b%5E...d2a4fe37e706

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications