[webkit-changes] [WebKit/WebKit] 845f0a: Consider ThirdPartyCookieBlockingMode::AllExceptPa...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 845f0a548125461da779d734a84b15498a4538cb
      https://github.com/WebKit/WebKit/commit/845f0a548125461da779d734a84b15498a4538cb
  Author: Matthew Finkel <m_finkel at apple.com>
  Date:   2025-01-28 (Tue, 28 Jan 2025)

  Changed paths:
    M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp
    M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h

  Log Message:
  -----------
  Consider ThirdPartyCookieBlockingMode::AllExceptPartitioned when deciding if cookie access should be granted via the Storage Access API
https://bugs.webkit.org/show_bug.cgi?id=286428
rdar://143508260

Reviewed by John Wilander and Brent Fulgham.

When handling a requestStorageAccess request, we considered storage access as
blocked only if all third-party cookies were blocked. In theory, this is true,
because the site has access to partitioned cookies, but that misses the point
of requesting storage access where the site gets access to its first party
cookies. This patch extends the current logic so it considers
AllExceptPartitioned as not currently having cookie access - therefore requires
handling the request for storage access.

Covered by existing tests.

* Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
(WebKit::ResourceLoadStatisticsStore::areAllUnpartitionedThirdPartyCookiesBlockedUnder):
(WebKit::ResourceLoadStatisticsStore::cookieAccess):
(WebKit::ResourceLoadStatisticsStore::areAllThirdPartyCookiesBlockedUnder): Deleted.
* Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:

Canonical link: https://commits.webkit.org/289450@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications