[webkit-changes] [WebKit/WebKit] 5c019b: [Ruby] Adding a margin-top on top of <rt> also add...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c019bf75a6395b9c14b94b50bb5a0fa8202a4ee
      https://github.com/WebKit/WebKit/commit/5c019bf75a6395b9c14b94b50bb5a0fa8202a4ee
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2025-01-28 (Tue, 28 Jan 2025)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/ruby-annotation-with-margin-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/ruby-annotation-with-margin-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/ruby-annotation-with-margin.html
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp

  Log Message:
  -----------
  [Ruby] Adding a margin-top on top of <rt> also adds a bottom margin
https://bugs.webkit.org/show_bug.cgi?id=286597

Reviewed by Antti Koivisto.

RubyFormattingContext::placeAnnotationBox is meant to return the _border_ box of the annotation content (fix is to offset the border top with margin before).

* LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/ruby-annotation-with-margin-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/ruby-annotation-with-margin-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/ruby-annotation-with-margin.html: Added.
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::placeAnnotationBox):

Canonical link: https://commits.webkit.org/289445@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications