[webkit-changes] [WebKit/WebKit] 18ac23: REGRESSION(289357 at main): [macOS iOS] 10 TestWebKit...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 18ac23068497fbfab7cff86d31eb67ce0df999da
      https://github.com/WebKit/WebKit/commit/18ac23068497fbfab7cff86d31eb67ce0df999da
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2025-01-28 (Tue, 28 Jan 2025)

  Changed paths:
    M Tools/TestWebKitAPI/NetworkConnection.mm

  Log Message:
  -----------
  REGRESSION(289357 at main): [macOS iOS] 10 TestWebKitAPI tests are failing/crashing (failure in EWS)
https://bugs.webkit.org/show_bug.cgi?id=286579
rdar://143703766

Reviewed by Per Arne Vollan and Alex Christensen.

In 289357 at main, I replaced the call to `atoi()` in Connection::receiveHTTPRequest()
with a call to parseInteger<int>(). This is normally identical except if there junk
at the end of the string. In this case, there is `\r\n` at the end of the string,
which `atoi()` used to ignore. As a result, call `parseIntegerAllowingTrailingJunk<int>()`
to maintain pre-existing behavior.

* Tools/TestWebKitAPI/NetworkConnection.mm:
(TestWebKitAPI::Connection::receiveHTTPRequest const):

Canonical link: https://commits.webkit.org/289433@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications