[webkit-changes] [WebKit/WebKit] dccfae: Media elements: Do not use getNonEmptyURLAttribute...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dccfae42bb29bd4bdef052e469f604a9387241c0
      https://github.com/WebKit/WebKit/commit/dccfae42bb29bd4bdef052e469f604a9387241c0
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc-expected.txt
    R LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc-expected.txt
    M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  -----------
  Media elements: Do not use getNonEmptyURLAttribute() in media source selection
https://bugs.webkit.org/show_bug.cgi?id=276509
rdar://132042925

Reviewed by Eric Carlson.

This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.

Merge: https://chromium.googlesource.com/chromium/src.git/+/0f1b99def010815efd548304136aa69441161c91

The specification [1] says:

" If the src attribute's value is the empty string, then end the synchronous section..." and onward.

This specification doesn't ask to strip whitespaces in 'src' attribute's value
though getNonEmptyURLAttribute(srcAttr) does.

[1] https://html.spec.whatwg.org/multipage/media.html#concept-media-load-algorithm

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::selectNextSourceChild):
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc-expected.txt: Deleted.

Canonical link: https://commits.webkit.org/289432@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications