[webkit-changes] [WebKit/WebKit] 6b740c: [cssom] Use shortest possible serialization for bo...

[Alexsander Borges Damaceno]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6b740c4e45079dbfba57ff6e8c558d91e490e0e7
      https://github.com/WebKit/WebKit/commit/6b740c4e45079dbfba57ff6e8c558d91e490e0e7
  Author: Alexsander Damaceno <aemgbo at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
    M LayoutTests/fast/css/getComputedStyle/computed-style-with-zoom-expected.txt
    M LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
    M LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-spacing-expected.txt
    M LayoutTests/fast/css/table-border-spacing-expected.txt
    M LayoutTests/fast/css/table-border-spacing.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-tables/inheritance-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-substitution-basic.html
    M LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/table-attribute.html
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-types.js
    M Source/WebCore/css/ComputedStyleExtractor.cpp

  Log Message:
  -----------
  [cssom] Use shortest possible serialization for border-spacing
https://bugs.webkit.org/show_bug.cgi?id=284724

Reviewed by Tim Nguyen.

Fix missing case in `border-spacing` serialisation. When the we have `border-spacing: 0px 0px`, we should apply the shortest serialization principle.
The WPT test was failing because we were serializing this configuration as "0px 0px" instead of "0px".

* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/parsing/border-spacing-computed-expected.txt:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/inheritance-expected.txt:
* LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt:
* LayoutTests/fast/css/getComputedStyle/computed-style-with-zoom-expected.txt:
* LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-spacing-expected.txt:
* LayoutTests/fast/css/table-border-spacing-expected.txt:
* LayoutTests/fast/css/table-border-spacing.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-substitution-basic.html:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/table-attribute.html:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-types.js:
(const.lengthPairType.testAdditionOrAccumulation):
(const.lengthPairType.testInterpolation):
(const.lengthPairType.testAdditionOrAccumulation):
(const.positionType.testInterpolation):
(const.positionType.testAdditionOrAccumulation):

Canonical link: https://commits.webkit.org/289431@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications