[webkit-changes] [WebKit/WebKit] be3fc6: [WebGPU] Mismatch between argument buffer index an...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: be3fc66ed9c7ef99ead328adef1fde24aba9b645
      https://github.com/WebKit/WebKit/commit/be3fc66ed9c7ef99ead328adef1fde24aba9b645
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/fuzz-286564-expected.txt
    A LayoutTests/fast/webgpu/nocrash/fuzz-286564.html
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp

  Log Message:
  -----------
  [WebGPU] Mismatch between argument buffer index and WGSL binding index
https://bugs.webkit.org/show_bug.cgi?id=286564
rdar://143628740

Reviewed by Tadeu Zagallo.

Dynamic offsets were placed into a container by argumentBufferIndex,
but looked up by bindingIndex.

Binding index is unique across all shader stages.

Argument buffer index may differ for the same binding across stages to
avoid creating holes in the AB.

Resolve this by performing the insertion by bindingIndex instead of AB index.

* LayoutTests/fast/webgpu/nocrash/fuzz-286564-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-286564.html: Added.
Add regression test.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::collectDynamicOffsetGlobals):

Canonical link: https://commits.webkit.org/289430@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications