[webkit-changes] [WebKit/WebKit] 4e7e8c: Align `selectorText` to not serialize `@page` and ...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e7e8cdf99fa7ad7c2779f5509d74f9d9fc9fc10
      https://github.com/WebKit/WebKit/commit/4e7e8cdf99fa7ad7c2779f5509d74f9d9fc9fc10
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M LayoutTests/fast/dom/css-element-attribute-js-null-expected.txt
    M LayoutTests/fast/dom/css-element-attribute-js-null.html
    M LayoutTests/http/wpt/cssom/CSSPageRule.html
    M LayoutTests/imported/w3c/resources/import-expectations.json
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/META.yml
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/WEB_FEATURES.yml
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/margin-001-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/margin-001.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/margin-002-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/margin-002.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/margin-003-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/margin-003.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/page-001-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/page-001.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/page-002-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/page-002.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/w3c-import.log
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/inheritance-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/inheritance.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-orientation.tentative-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-orientation.tentative.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-000-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-000.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-001-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-001.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-002-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-002.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-003-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-003.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-004-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-004.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/WEB_FEATURES.yml
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/margin-rules-001-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/margin-rules-001.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/margin-rules-002-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/margin-rules-002.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/nested-rules-001-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/nested-rules-001.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-computed-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-computed.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-invalid-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-invalid.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-orientation-computed.tentative-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-orientation-computed.tentative.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-orientation-invalid.tentative-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-orientation-invalid.tentative.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-rules-001-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-rules-001.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-valid-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-valid.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/w3c-import.log
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/trailing-declaration-crash.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-page/w3c-import.log
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssom-pagerule-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssom-pagerule.html
    M Source/WebCore/css/CSSPageRule.cpp
    M Source/WebCore/css/CSSPageRule.idl

  Log Message:
  -----------
  Align `selectorText` to not serialize `@page` and not be nullable  as per Web Specification

https://bugs.webkit.org/show_bug.cgi?id=271432
rdar://125588212

Reviewed by Darin Adler.

This patch aligns WebKit with Web Specification [1] & [2]:

[1] https://drafts.csswg.org/cssom/#dom-csspagerule-selectortext
[2] https://drafts.csswg.org/cssom/#csspagerule

As per Web Specification, it should not append `@page`, so now
it serialize correctly. Similarly, it should not be nullable.

This patch also syncs WPT tests (not printing specific) below:

Upstream commit: https://github.com/web-platform-tests/wpt/commit/c72ee0c082d350b8b44f7a6bac1f028752b13527

* Source/WebCore/css/CSSPageRule.cpp:
(WebCore::CSSPageRule::selectorText const):
(WebCore::CSSPageRule::cssText const):
* Source/WebCore/css/CSSPageRule.idl:

> Rebaselines (Local Tests)
* LayoutTests/http/wpt/cssom/CSSPageRule.html: Updated
* LayoutTests/fast/dom/css-element-attribute-js-null-expected.txt: Synced from Blink Source
* LayoutTests/fast/dom/css-element-attribute-js-null.html: Synced from Blink Source

> WPT Tests Update & Sync:
* LayoutTests/imported/w3c/resources/import-expectations.json:
* * LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssom-pagerule.html: Extended for `cssText` cases as well
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssom-pagerule-expected.txt: Rebaselined
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/margin-001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/margin-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/margin-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/margin-002.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/margin-003-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/margin-003.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/page-001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/page-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/page-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/page-002.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/cssom/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/inheritance-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/inheritance.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/META.yml:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-orientation.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-orientation.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-000-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-000.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-002.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-003-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-003.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-004-expected.txt::
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/page-rule-declarations-004.html::
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/margin-rules-001-expected.txt::
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/margin-rules-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/margin-rules-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/margin-rules-002.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/nested-rules-001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/nested-rules-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-computed.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-invalid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-invalid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-orientation-computed.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-orientation-computed.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-orientation-invalid.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-orientation-invalid.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-rules-001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-rules-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/page-valid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/parsing/WEB_FEATURES.yml:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/trailing-declaration-crash.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-page/WEB_FEATURES.yml:

Canonical link: https://commits.webkit.org/289428@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications