[webkit-changes] [WebKit/WebKit] 62c52e: [Cleanup] RenderTreeBuilder::Inline::continuationB...

Alan Baradlay noreply at github.com
Mon Jan 27 06:43:47 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62c52e06a509877cc4a89312a62662274d7fed47
      https://github.com/WebKit/WebKit/commit/62c52e06a509877cc4a89312a62662274d7fed47
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilderInline.h
    M Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp

  Log Message:
  -----------
  [Cleanup] RenderTreeBuilder::Inline::continuationBefore doesn't do any "continuation before"
https://bugs.webkit.org/show_bug.cgi?id=286546

Reviewed by Antti Koivisto.

1. Rename RenderTreeBuilder::Inline::continuationBefore to parentCandidateInContinuation
2. Sprinkle these functions with CheckedPtr
3. Fix some misleading names

* Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp:
(WebCore::nextContinuation):
(WebCore::RenderTreeBuilder::Inline::parentCandidateInContinuation):
(WebCore::RenderTreeBuilder::Inline::insertChildToContinuation):
(WebCore::RenderTreeBuilder::Inline::continuationBefore): Deleted.
* Source/WebCore/rendering/updating/RenderTreeBuilderInline.h:
* Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp:
(WebCore::RenderTreeBuilder::Ruby::findOrCreateParentForStyleBasedRubyChild):

Canonical link: https://commits.webkit.org/289426@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list