[webkit-changes] [WebKit/WebKit] 3b5561: [Skia][cairo] TestWebCore.ImageBufferTests.ImageBu...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b5561ce3cda7ad90dd199d3ceebc1d58a95fdeb
      https://github.com/WebKit/WebKit/commit/3b5561ce3cda7ad90dd199d3ceebc1d58a95fdeb
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2025-01-26 (Sun, 26 Jan 2025)

  Changed paths:
    M Source/WebCore/platform/graphics/cairo/ImageBufferCairoSurfaceBackend.cpp
    M Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.cpp
    M Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp
    M Tools/TestWebKitAPI/CMakeLists.txt
    M Tools/TestWebKitAPI/WebCoreTestUtilities.cpp
    M Tools/TestWebKitAPI/glib/TestExpectations.json

  Log Message:
  -----------
  [Skia][cairo] TestWebCore.ImageBufferTests.ImageBufferSubPixelDrawing fails
https://bugs.webkit.org/show_bug.cgi?id=286406

Reviewed by Carlos Garcia Campos.

TestWebCore.ImageBufferTests.ImageBufferSubPixelDrawing was failing
for Skia and cairo ports because the device scale factor wasn't
applied to ImageBuffer.

Windows Skia port was freezing while destroying skiaGLContext now. It
doesn's support accelerated image buffer yet. Disabled skiaGLContext
for now.

The tests are skipped for GTK and WPE ports now. <https://webkit.org/b/286456>
Only tested with Windows Cairo and Windows Skia ports.

* Source/WebCore/platform/graphics/cairo/ImageBufferCairoSurfaceBackend.cpp:
(WebCore::ImageBufferCairoSurfaceBackend::ImageBufferCairoSurfaceBackend):
* Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.cpp:
(WebCore::ImageBufferSkiaSurfaceBackend::ImageBufferSkiaSurfaceBackend):
* Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp:
(WebCore::PlatformDisplay::skiaGLContext):
* Tools/TestWebKitAPI/CMakeLists.txt:
* Tools/TestWebKitAPI/WebCoreTestUtilities.cpp:
* Tools/TestWebKitAPI/glib/TestExpectations.json:

Canonical link: https://commits.webkit.org/289415@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications