[webkit-changes] [WebKit/WebKit] ddfb6b: Use smart pointers to store reference to CanvasBas...

[Fady Farag]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ddfb6b7d179b45962c4a7f15d264417f9601a30f
      https://github.com/WebKit/WebKit/commit/ddfb6b7d179b45962c4a7f15d264417f9601a30f
  Author: Fady Farag <com.idmsa at gmail.com>
  Date:   2025-01-26 (Sun, 26 Jan 2025)

  Changed paths:
    M Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
    M Source/WebCore/html/CanvasBase.h
    M Source/WebCore/html/CustomPaintCanvas.h
    M Source/WebCore/html/HTMLCanvasElement.h
    M Source/WebCore/html/OffscreenCanvas.h
    M Source/WebCore/html/canvas/CanvasRenderingContext.cpp
    M Source/WebCore/html/canvas/CanvasRenderingContext.h

  Log Message:
  -----------
  Use smart pointers to store reference to CanvasBase in CanvasRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=286535
rdar://problem/143630378

Reviewed by Chris Dumez and Darin Adler.

Fix a clang static analyzer warning caused by using a raw reference to
store the owning CanvasBase in CanvasRenderingContext. Since CanvasBase
owns CanvasRenderingContext I resorted to using a `WeakRef`.

* Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebCore/html/CanvasBase.h:
* Source/WebCore/html/HTMLCanvasElement.h:
* Source/WebCore/html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::ref const):
(WebCore::CanvasRenderingContext::deref const):
(WebCore::CanvasRenderingContext::taintsOrigin):
(WebCore::CanvasRenderingContext::checkOrigin):
* Source/WebCore/html/canvas/CanvasRenderingContext.h:
(WebCore::CanvasRenderingContext::checkOrigin):

Canonical link: https://commits.webkit.org/289414@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications