[webkit-changes] [WebKit/WebKit] cd2260: Reduce use of strcmp() / strncmp() in the codebase

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cd22602acd1a62f94e7f60245d6332f2f15f1078
      https://github.com/WebKit/WebKit/commit/cd22602acd1a62f94e7f60245d6332f2f15f1078
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2025-01-25 (Sat, 25 Jan 2025)

  Changed paths:
    M Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h
    M Source/WebCore/PAL/pal/text/TextCodecICU.cpp
    M Source/WebCore/css/typedom/CSSNumericValue.cpp
    M Source/WebCore/dom/TextDecoder.cpp
    M Source/WebCore/page/PrintContext.cpp
    M Source/WebCore/page/PrintContext.h
    M Source/WebCore/platform/SharedMemory.cpp
    M Source/WebCore/platform/cocoa/AGXCompilerService.cpp
    M Source/WebCore/platform/graphics/cocoa/WebMAudioUtilitiesCocoa.mm
    M Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp
    M Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp
    M Source/WebCore/platform/mac/CursorMac.mm
    M Source/WebCore/platform/sql/SQLiteFileSystem.cpp
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp
    M Source/WebDriver/WebDriverService.cpp
    M Source/WebKit/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFScriptEvaluation.mm
    M Source/WebKitLegacy/mac/WebView/WebPDFDocumentExtras.mm
    M Tools/Scripts/webkitpy/style/checkers/cpp.py
    M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

  Log Message:
  -----------
  Reduce use of strcmp() / strncmp() in the codebase
https://bugs.webkit.org/show_bug.cgi?id=286519

Reviewed by Geoffrey Garen.

Reduce use of strcmp() / strncmp() in the codebase as they are considered unsafe.

* Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:
(CGPDFDictionaryGetNameString):
* Source/WebCore/PAL/pal/text/TextCodecICU.cpp:
(PAL::TextCodecICU::createICUConverter const):
* Source/WebCore/css/typedom/CSSNumericValue.cpp:
(WebCore::CSSNumericValue::toSum):
* Source/WebCore/dom/TextDecoder.cpp:
(WebCore::TextDecoder::create):
* Source/WebCore/page/PrintContext.cpp:
(WebCore::PrintContext::pageProperty):
* Source/WebCore/page/PrintContext.h:
* Source/WebCore/platform/SharedMemory.cpp:
(WebCore::isMemoryAttributionDisabled):
* Source/WebCore/platform/cocoa/AGXCompilerService.cpp:
(WebCore::deviceHasAGXCompilerService):
* Source/WebCore/platform/graphics/cocoa/WebMAudioUtilitiesCocoa.mm:
(WebCore::parseOpusPrivateData):
* Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::parse):
* Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::decodingWarning):
* Source/WebCore/platform/mac/CursorMac.mm:
(WebCore::cursor):
(WebCore::Cursor::ensurePlatformCursor const):
* Source/WebCore/platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::setCanSuspendLockedFileAttribute):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::pageProperty const):
* Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::attributesStartElementNsHandler):
* Source/WebDriver/WebDriverService.cpp:
(WebDriver::WebDriverService::run):
* Source/WebKit/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:
(-[_WKRemoteObjectRegistry _sendInvocation:interface:]):
(-[_WKRemoteObjectRegistry _invokeMethod:]):
* Source/WebKit/WebProcess/Plugins/PDF/PDFScriptEvaluation.mm:
(WebKit::PDFScriptEvaluation::pdfDocumentContainsPrintScript):
* Source/WebKitLegacy/mac/WebView/WebPDFDocumentExtras.mm:
(allScriptsInPDFDocument):
* Tools/Scripts/webkitpy/style/checkers/cpp.py:
(check_safer_cpp):
(CppChecker):
* Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_safer_cpp):

Canonical link: https://commits.webkit.org/289399@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications