[webkit-changes] [WebKit/WebKit] 47bb88: Reduce use of strchr() in the codebase

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 47bb88f5f7e710aae31d46a5225dde4e20607976
      https://github.com/WebKit/WebKit/commit/47bb88f5f7e710aae31d46a5225dde4e20607976
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2025-01-25 (Sat, 25 Jan 2025)

  Changed paths:
    M Source/WebCore/Modules/websockets/WebSocketExtensionParser.cpp
    M Source/WebCore/PAL/pal/text/TextEncodingRegistry.cpp
    M Source/WebCore/loader/FTPDirectoryParser.cpp
    M Source/WebCore/page/linux/ResourceUsageThreadLinux.cpp
    M Source/WebCore/platform/network/FormDataBuilder.cpp
    M Source/WebCore/platform/text/SegmentedString.cpp
    M Source/WebCore/platform/text/SegmentedString.h
    M Source/WebKitLegacy/mac/Misc/WebNSObjectExtras.mm
    M Tools/DumpRenderTree/mac/DumpRenderTree.mm
    M Tools/Scripts/webkitpy/style/checkers/cpp.py
    M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm
    M Tools/WebKitTestRunner/TestController.cpp
    M Tools/WebKitTestRunner/TestController.h
    M Tools/WebKitTestRunner/win/EventSenderProxyWin.cpp

  Log Message:
  -----------
  Reduce use of strchr() in the codebase
https://bugs.webkit.org/show_bug.cgi?id=286498

Reviewed by Michael Catanzaro.

Reduce use of strchr() in the codebase as it is considered unsafe. Use `find()`
or `contains()` instead, which work with spans.

* Source/WebCore/Modules/websockets/WebSocketExtensionParser.cpp:
(WebCore::isSeparator):
* Source/WebCore/PAL/pal/text/TextEncodingRegistry.cpp:
(PAL::isUndesiredAlias):
* Source/WebCore/loader/FTPDirectoryParser.cpp:
(WebCore::parseOneFTPLine):
* Source/WebCore/page/linux/ResourceUsageThreadLinux.cpp:
(WebCore::threadCPUUsage):
* Source/WebCore/platform/network/FormDataBuilder.cpp:
(WebCore::FormDataBuilder::appendFormURLEncoded):
* Source/WebCore/platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::advancePastSlowCase):
* Source/WebCore/platform/text/SegmentedString.h:
(WebCore::SegmentedString::advancePast):
* Source/WebKitLegacy/mac/Misc/WebNSObjectExtras.mm:
(returnTypeIsObject):
* Tools/DumpRenderTree/mac/DumpRenderTree.mm:
(handleControlCommand):
(runTestingServerLoop):
(overrideIsInHardwareKeyboardMode): Deleted.
(prepareConsistentTestingEnvironment): Deleted.
(writeCrashedMessageOnFatalError): Deleted.
(dumpRenderTree): Deleted.
(atexitFunction): Deleted.
(DumpRenderTreeMain): Deleted.
(compareHistoryItems): Deleted.
(dumpAudio): Deleted.
(dumpHistoryItem): Deleted.
(dumpFrameScrollPosition): Deleted.
(dumpFramesAsText): Deleted.
(dumpFrameAsPDF): Deleted.
(dumpBackForwardListForWebView): Deleted.
(changeWindowScaleIfNeeded): Deleted.
(sizeWebViewForCurrentTest): Deleted.
(methodNameStringForFailedTest): Deleted.
(dumpBackForwardListForAllWindows): Deleted.
(invalidateAnyPreviousWaitToDumpWatchdog): Deleted.
(setWaitToDumpWatchdog): Deleted.
(shouldSetWaitToDumpWatchdog): Deleted.
(updateDisplay): Deleted.
(dump): Deleted.
(shouldLogFrameLoadDelegates): Deleted.
(shouldLogHistoryDelegates): Deleted.
(shouldDumpAsText): Deleted.
(shouldMakeViewportFlexible): Deleted.
(shouldUseEphemeralSession): Deleted.
(setJSCOptions): Deleted.
(resetWebViewToConsistentState): Deleted.
(WebThreadLockAfterDelegateCallbacksHaveCompleted): Deleted.
(computeTestURL): Deleted.
(testOptionsForTest): Deleted.
(runTest): Deleted.
(displayWebView): Deleted.
(displayAndTrackRepaintsWebView): Deleted.
* Tools/ImageDiff/ImageDiff.cpp:
(main):
* Tools/Scripts/webkitpy/style/checkers/cpp.py:
(check_safer_cpp):
(CppChecker):
* Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_safer_cpp):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
(TEST(WebKit, PDFLinkReferrer)):
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::handleControlCommand):
(WTR::TestController::runTestingServerLoop):
* Tools/WebKitTestRunner/TestController.h:
* Tools/WebKitTestRunner/win/EventSenderProxyWin.cpp:
(WTR::EventSenderProxy::keyDown):

Canonical link: https://commits.webkit.org/289391@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications