[webkit-changes] [WebKit/WebKit] 37b9a8: Unified PDF doesn't build with ENABLE(REVEAL) or E...

Tim Horton noreply at github.com
Fri Jan 24 20:30:24 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37b9a8a208fdc616941761787da97c8aa1a12043
      https://github.com/WebKit/WebKit/commit/37b9a8a208fdc616941761787da97c8aa1a12043
  Author: Tim Horton <thorton at apple.com>
  Date:   2025-01-24 (Fri, 24 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm

  Log Message:
  -----------
  Unified PDF doesn't build with ENABLE(REVEAL) or ENABLE(DRAG_SUPPORT) off
https://bugs.webkit.org/show_bug.cgi?id=286517
rdar://143588122

Reviewed by Richard Robinson, Wenson Hsieh, Aditya Keerthi, Simon Fraser, and Abrar Rahman Protyasha.

Fix a few tiny mistakes:

* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
This PDF code was accidentally inside a dragging related #ifdef.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::textForImmediateActionHitTestAtPoint):
This code assumed ENABLE(REVEAL) was always true.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:
This code didn't include the definition of UIWKDocumentContext and friends.

Canonical link: https://commits.webkit.org/289378@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list