[webkit-changes] [WebKit/WebKit] 868dca: With declarative web push enabled, push subscripti...

[Brady Eidson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 868dca74924458d3817cf2055f1f2f31c5459956
      https://github.com/WebKit/WebKit/commit/868dca74924458d3817cf2055f1f2f31c5459956
  Author: Brady Eidson <beidson at apple.com>
  Date:   2025-01-24 (Fri, 24 Jan 2025)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkSession.cpp
    M Source/WebKit/NetworkProcess/NetworkSession.h
    M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm

  Log Message:
  -----------
  With declarative web push enabled, push subscriptions should outlive service workers
rdar://143445171
https://bugs.webkit.org/show_bug.cgi?id=286516

Reviewed by Richard Robinson.

When WKWebsiteDataStore API is used to remove all website data (especially ServiceWorkers),
we should still remove push subscriptions.

But when ITP removes a service worker, or the service worker is unregistered by JavaScript,
and declarative web push is enabled, then the push subscription should outlive the service worker.

* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
* Source/WebKit/NetworkProcess/NetworkSession.cpp:
(WebKit::m_isDeclarativeWebPushEnabled):
* Source/WebKit/NetworkProcess/NetworkSession.h:
(WebKit::NetworkSession::isDeclarativeWebPushEnabled const):
* Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::resolveUnregistrationJobInClient):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:
(TestWebKitAPI::(WebPushDTest, UnsubscribesOnServiceWorkerUnregisterTest)):

Canonical link: https://commits.webkit.org/289377@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications