[webkit-changes] [WebKit/WebKit] 577fb0: [Screen Time Refactoring] Ensure donations do not ...

Jessica Cheung noreply at github.com
Fri Jan 24 15:54:03 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 577fb0fa5f923e6c550e5d557380e7e3ed663a70
      https://github.com/WebKit/WebKit/commit/577fb0fa5f923e6c550e5d557380e7e3ed663a70
  Author: Jessica Cheung <jcheung23 at apple.com>
  Date:   2025-01-24 (Fri, 24 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ScreenTime.mm

  Log Message:
  -----------
  [Screen Time Refactoring] Ensure donations do not occur in private browsing / ephemeral sessions
https://bugs.webkit.org/show_bug.cgi?id=286493
rdar://140439254

Reviewed by Aditya Keerthi and Wenson Hsieh.

Set suppressUsageRecording on a STWebpageController to ensure
screen time donations are not accounted during
private browsing or ephemeral sessions.

Added API tests to ensure flag is being set properly.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _installScreenTimeWebpageController]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ScreenTime.mm:
(testSuppressUsageRecordingWithDataStore):
(TEST(ScreenTime, PersistentSession)):
(TEST(ScreenTime, NonPersistentSession)):

Canonical link: https://commits.webkit.org/289370@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list