[webkit-changes] [WebKit/WebKit] b3dac5: [style-checker] Update warnings for use of `_VERSI...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b3dac5b6a0a57ece20cd1ea8a6069cfa90a6ba47
      https://github.com/WebKit/WebKit/commit/b3dac5b6a0a57ece20cd1ea8a6069cfa90a6ba47
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2025-01-24 (Fri, 24 Jan 2025)

  Changed paths:
    M Tools/Scripts/webkitpy/style/checkers/cpp.py
    M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

  Log Message:
  -----------
  [style-checker] Update warnings for use of `_VERSION_MIN_REQUIRED` and `_VERSION_MAX_ALLOWED` macros to reflect current reality
https://bugs.webkit.org/show_bug.cgi?id=286176
rdar://143160437

Reviewed by Alexey Proskuryakov and Elliott Williams.

As of macOS 11, it is no longer the case that `__MAC_OS_X_VERSION_MIN_REQUIRED`
does not work for minor versions. Additionally, non-macOS platforms also support
use of `_VERSION_MIN_REQUIRED` with minor versions.

Tiny versions continue to be unsupported for both macros. Thus, the
`_VERSION_MIN_REQUIRED` is relaxed to check `% 100` for all platforms,
and an equivalent check for `_VERSION_MAX_ALLOWED` is introduced.

* Tools/Scripts/webkitpy/style/checkers/cpp.py:
(check_os_version_checks):
* Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest):

Add tests and update existing tests to reflect the minimum support macOS version.

Canonical link: https://commits.webkit.org/289361@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications