[webkit-changes] [WebKit/WebKit] b7a414: Reduce use of atoi() in the codebase

Chris Dumez noreply at github.com
Fri Jan 24 11:10:13 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b7a414ec0e71197b82ee184f048300aeea5e4630
      https://github.com/WebKit/WebKit/commit/b7a414ec0e71197b82ee184f048300aeea5e4630
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2025-01-24 (Fri, 24 Jan 2025)

  Changed paths:
    M Source/JavaScriptCore/runtime/VM.cpp
    M Source/JavaScriptCore/testmem/testmem.cpp
    M Source/JavaScriptCore/testmem/testmem.mm
    M Tools/Scripts/webkitpy/style/checkers/cpp.py
    M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
    M Tools/TestRunnerShared/IOSLayoutTestCommunication.cpp
    M Tools/TestRunnerShared/TestCommand.cpp
    M Tools/TestWebKitAPI/NetworkConnection.mm

  Log Message:
  -----------
  Reduce use of atoi() in the codebase
https://bugs.webkit.org/show_bug.cgi?id=286335

Reviewed by Darin Adler.

Reduce use of atoi() in the codebase as it is considered unsafe.
Use the pre-existing parseInteger<int>() function instead which takes in
a span.

* Source/JavaScriptCore/runtime/VM.cpp:
(JSC::enableAssembler):
* Source/JavaScriptCore/testmem/testmem.cpp:
(main):
* Source/JavaScriptCore/testmem/testmem.mm:
(main):
* Tools/Scripts/webkitpy/style/checkers/cpp.py:
(check_safer_cpp):
(CppChecker):
* Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_safer_cpp):
* Tools/TestRunnerShared/IOSLayoutTestCommunication.cpp:
(setUpIOSLayoutTestCommunication):
* Tools/TestRunnerShared/TestCommand.cpp:
(WTR::parseInputLine):
* Tools/TestWebKitAPI/NetworkConnection.mm:
(TestWebKitAPI::Connection::receiveHTTPRequest const):

Canonical link: https://commits.webkit.org/289357@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list