[webkit-changes] [WebKit/WebKit] 3b6a05: [Intelligence Effects] Smart Replies animation fli...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b6a05692af693c269419e4486ddd1ac1190d5a6
      https://github.com/WebKit/WebKit/commit/3b6a05692af693c269419e4486ddd1ac1190d5a6
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2025-01-24 (Fri, 24 Jan 2025)

  Changed paths:
    M Source/WebCore/dom/DocumentMarkerController.cpp
    M Source/WebCore/dom/DocumentMarkerController.h
    M Source/WebCore/page/writing-tools/WritingToolsController.h
    M Source/WebCore/page/writing-tools/WritingToolsController.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
    M Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.h
    M Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm
    M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebKitSwift/WebKitSwift.h
    M Source/WebKit/WebKitSwift/WritingTools/IntelligenceTextEffectViewManager.swift
    M Source/WebKit/WebKitSwift/WritingTools/PlatformIntelligenceTextEffectView.swift
    A Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceSmartReplyTextEffectCoordinator.h
    A Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceSmartReplyTextEffectCoordinator.swift
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  -----------
  [Intelligence Effects] Smart Replies animation flickers / doesn't animate smoothly
https://bugs.webkit.org/show_bug.cgi?id=286231
rdar://143206029

Reviewed by Aditya Keerthi.

Refactor the Smart Replies implementation to use the new intelligence effects system, which fixes the existing
flickering and broken animations in the current implementation.

* Source/WebCore/dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::addMarker):
(WebCore::DocumentMarkerController::addTransparentContentMarker):
(WebCore::DocumentMarkerController::applyToCollapsedRangeMarker):
(WebCore::DocumentMarkerController::forEach<DocumentMarkerController::IterationDirection::Forwards>):
(WebCore::DocumentMarkerController::forEach<DocumentMarkerController::IterationDirection::Backwards>):
(WebCore::addMarker):
* Source/WebCore/dom/DocumentMarkerController.h:
(WebCore::addMarker):
* Source/WebCore/page/writing-tools/WritingToolsController.h:
* Source/WebCore/page/writing-tools/WritingToolsController.mm:
(WebCore::WritingToolsController::smartReplySessionDidReceiveTextWithReplacementRange):
(WebCore::WritingToolsController::compositionSessionDidReceiveTextWithReplacementRange):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView didBeginWritingToolsSession:contexts:]):
(-[WKWebView didEndWritingToolsSession:accepted:]):
(-[WKWebView compositionSession:didReceiveText:replacementRange:inContext:finished:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.h:
* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm:
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::compositionSessionDidReceiveTextWithReplacementRange):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebKitSwift/WebKitSwift.h:
* Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceSmartReplyTextEffectCoordinator.h: Copied from Source/WebKit/WebKitSwift/WebKitSwift.h.
* Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceSmartReplyTextEffectCoordinator.swift: Added.
(WKIntelligenceSmartReplyTextEffectCoordinator.onFlushCompletion):
(WKIntelligenceSmartReplyTextEffectCoordinator.hasActiveEffects):
(WKIntelligenceSmartReplyTextEffectCoordinator.startAnimation(for:)):
(WKIntelligenceSmartReplyTextEffectCoordinator.requestReplacement(withProcessedRange:finished:characterDelta:operation:)):
(WKIntelligenceSmartReplyTextEffectCoordinator.flushReplacements):
(WKIntelligenceSmartReplyTextEffectCoordinator.restoreSelection(_:)):
(WKIntelligenceSmartReplyTextEffectCoordinator.hideEffects):
(WKIntelligenceSmartReplyTextEffectCoordinator.showEffects):
(WKIntelligenceSmartReplyTextEffectCoordinator.removeActiveEffects):
(WKIntelligenceSmartReplyTextEffectCoordinator.startReplacementAnimation(withProcessedRange:characterDelta:operation:)):
(WKIntelligenceSmartReplyTextEffectCoordinator.reset):
(WKIntelligenceSmartReplyTextEffectCoordinator.updateTextChunkVisibility(_:visible:force:)):
(WKIntelligenceSmartReplyTextEffectCoordinator.textPreview(for:)):
(WKIntelligenceSmartReplyTextEffectCoordinator.updateTextChunkVisibility(_:visible:)):
(WKIntelligenceSmartReplyTextEffectCoordinator.performReplacementAndGeneratePreview(for:effect:remainder:)):
(WKIntelligenceSmartReplyTextEffectCoordinator.replacementEffectWillBegin(_:)):
(WKIntelligenceSmartReplyTextEffectCoordinator.replacementEffectDidComplete(_:)):
(async(_:)):
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::compositionSessionDidReceiveTextWithReplacementRange):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/289354@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications