[webkit-changes] [WebKit/WebKit] be74ad: [WGSL] Generated metal does not compile from https...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: be74adeaac4cb1b243fd11f2bcc3d2bb267d6b8c
      https://github.com/WebKit/WebKit/commit/be74adeaac4cb1b243fd11f2bcc3d2bb267d6b8c
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2025-01-24 (Fri, 24 Jan 2025)

  Changed paths:
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
    A Source/WebGPU/WGSL/tests/valid/packing-nested-array.wgsl

  Log Message:
  -----------
  [WGSL] Generated metal does not compile from https://playcanvas.vercel.app/#/graphics/particles-mesh
https://bugs.webkit.org/show_bug.cgi?id=286005
rdar://142975586

Reviewed by Mike Wyrzykowski.

While packing types, when visiting arrays of vec3 we marked that vec3 is used,
but failed to mark that the array is also used, which could result in the array
helpers missings from the generated metal code.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::packArrayType):
* Source/WebGPU/WGSL/tests/valid/packing-nested-array.wgsl: Added.

Canonical link: https://commits.webkit.org/289344@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications